From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Sat, 24 Jul 2021 02:33:21 -0700 Message-ID: <865yx09hum.fsf@stephe-leake.org> References: <83h7gw6pyj.fsf@gnu.org> <45EBF16A-C953-42C7-97D1-3A2BFEF7DD01@gmail.com> <83y2a764oy.fsf@gnu.org> <83v95b60fn.fsf@gnu.org> <00DD5BFE-D14E-449A-9319-E7B725DEBFB3@gmail.com> <83r1fz5xr9.fsf@gnu.org> <1AAB1BCC-362B-4249-B785-4E0530E15C60@gmail.com> <83czri67h0.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11757"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) Cc: Eli Zaretskii , emacs-devel@gnu.org, =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel , Stefan Monnier To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 24 11:34:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7E2j-0002oN-U9 for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 11:34:02 +0200 Original-Received: from localhost ([::1]:34466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7E2i-00068n-UQ for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 05:34:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7E2D-0005Rq-I2 for emacs-devel@gnu.org; Sat, 24 Jul 2021 05:33:29 -0400 Original-Received: from gateway22.websitewelcome.com ([192.185.46.234]:25956) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7E2B-0001U3-CR for emacs-devel@gnu.org; Sat, 24 Jul 2021 05:33:29 -0400 Original-Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 271D85964 for ; Sat, 24 Jul 2021 04:33:26 -0500 (CDT) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id 7E29mR1YYoIHn7E2AmckdH; Sat, 24 Jul 2021 04:33:26 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/YVtnUchXOsfaBavBk63lycGbcdXDRj5anCgUD7oVaw=; b=Gtf+rGPbwZuCIDdqcfJ31IxkBI 9YkN4h44K7gXg+yxHpEgxiwt4tK/OfNpuiTJFZnTuKnrMS6EJ4zbGVPEy22DNbqYjJB/n9DTOerUE 9JQTeDDFEt/CxOYDvG2ploWEg1SY/nIrbn3QgpBSk/NDqdLaeTYixcYDxSL2wHIGDGn4WdxoVGvXp 0FMlLPSMnKlW9qKV1ePyynR2pq/mwViVCCkXSfueJiEJF3+XGgmKJdHbR6uL7zUwDe5KhEBHTmQ4d hfy/Q5q7mYc7Ga3vjpN2PNWVyalHw8N4T7CNy5cNQJWGc1ZTFhDBexlFiH6fV5CFTErxAbpR9ZGtw IHQG7cjQ==; Original-Received: from [76.77.182.20] (port=52412 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m7E29-003Ig9-D2; Sat, 24 Jul 2021 03:33:25 -0600 In-Reply-To: <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> (Yuan Fu's message of "Thu, 22 Jul 2021 09:47:45 -0400") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1m7E29-003Ig9-D2 X-Source-Sender: (Takver4) [76.77.182.20]:52412 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 5 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: permerror client-ip=192.185.46.234; envelope-from=stephen_leake@stephe-leake.org; helo=gateway22.websitewelcome.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271531 Archived-At: Yuan Fu writes: >>=20 >>> + // TODO BUF_ZV_BYTE? >>=20 >> Do you want to discuss this? I'd prefer to have it the other way >> around: use BUF_ZV_BYTE by default. The callers could widen the >> buffer if they needed to access outside of the narrowing. > > Yes, I meant to discuss this. The problem with respecting narrowing is > that, a user can freely narrow and widen arbitrarily, and Emacs needs > to translate them into insertion & deletion of the buffer text for > tree-sitter, every time a user narrows or widens the buffer.=20 I don't think that's the right thing to do. tree-sitter should always have a tree that represents the entire buffer; if the user narrows, edits will only affect the narrowed region, but tree-sitter won't notice that, and won't care. In particular, that means buffer positions reported by tree-sitter will match emacs buffer positions. > Plus, if tree-sitter respects narrowing, it could happen where a user > narrows the buffer, the font-locking changes and is not correct > anymore. Maybe that=E2=80=99s not the user want.=20 Exactly. The indent will be wrong, too, if narrowing excludes a containing block. --=20 -- Stephe