From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Sun, 25 Jul 2021 09:49:49 -0700 Message-ID: <865ywy8hjm.fsf@stephe-leake.org> References: <83h7gw6pyj.fsf@gnu.org> <45EBF16A-C953-42C7-97D1-3A2BFEF7DD01@gmail.com> <83y2a764oy.fsf@gnu.org> <83v95b60fn.fsf@gnu.org> <00DD5BFE-D14E-449A-9319-E7B725DEBFB3@gmail.com> <83r1fz5xr9.fsf@gnu.org> <1AAB1BCC-362B-4249-B785-4E0530E15C60@gmail.com> <83czri67h0.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <83lf654dhk.fsf@gnu.org> <2524265f-60c7-24f5-b9f4-98447c91acab@gmail.com> <86o8av4olc.fsf@stephe-leake.org> <976cd611-52b3-5280-263e-ab8e3db8a355@gmail.com> <83k0lj4fml.fsf@gnu.org> <86a6mca06b.fsf@stephe-leake.org> <87wnpggz36.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4113"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) Cc: emacs-devel@gnu.org To: =?utf-8?Q?=C3=93scar?= Fuentes Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 25 18:51:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7hLC-0000uA-O7 for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Jul 2021 18:51:03 +0200 Original-Received: from localhost ([::1]:53662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7hLB-0003N1-PM for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Jul 2021 12:51:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7hK7-0002ge-Ap for emacs-devel@gnu.org; Sun, 25 Jul 2021 12:49:55 -0400 Original-Received: from gateway31.websitewelcome.com ([192.185.144.94]:38643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7hK5-0003uD-95 for emacs-devel@gnu.org; Sun, 25 Jul 2021 12:49:55 -0400 Original-Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 82082123BC for ; Sun, 25 Jul 2021 11:49:51 -0500 (CDT) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id 7hK3mKKBCMGeE7hK3miTyS; Sun, 25 Jul 2021 11:49:51 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7DHg3nn/7G4XTjOEb8IYS1Alpbg4zQNBK+mwHsvNtKo=; b=kPgUkG5yaSUjDKPnLbjc78yRTE uJObnCMV2i0USJZLcItJYgZh+xgDxc+GrXIH3lDMydSJwQOfxbvpTDPhMwyAZWI5udcQ6sLu2YkDj G11jxZcw1Wfy0YqsDPQgft7/C1qlSXkZUju8j8JlKBn3taaevFnClupzeAZf/WIH/UWuCpOfaQsy/ 2Hq2Agh1CpdskKmsVNnnDQjwW6rF7flJwODzw9Yt/K6kh9yTNrywmRVo/T7hdIVuie720tE7wJ9ih Q0TCMSrr1Cfee2CIFp1bEDqBeFPuNn+qeFCILuCtjhNPQTqf6SKB28Sn4YWM8Ec+vGFFe9Deu/Uf+ UtL5aQVQ==; Original-Received: from [76.77.182.20] (port=57093 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m7hK2-003uVh-T5; Sun, 25 Jul 2021 10:49:50 -0600 In-Reply-To: <87wnpggz36.fsf@telefonica.net> (=?utf-8?Q?=22=C3=93scar?= Fuentes"'s message of "Sat, 24 Jul 2021 05:39:09 +0200") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1m7hK2-003uVh-T5 X-Source-Sender: (Takver4) [76.77.182.20]:57093 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 9 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: permerror client-ip=192.185.144.94; envelope-from=stephen_leake@stephe-leake.org; helo=gateway31.websitewelcome.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271616 Archived-At: =C3=93scar Fuentes writes: > Stephen Leake writes: > >> 39 milliseconds for re-indent is just slow enough to be noticeable; I st= ill >> have algorithms to convert to be as incremental as possible. > > [snip] > >> In a very small file: >> >> initial 0.000632 seconds >> re-indent 0.000942 seconds >> >> Easily fast enough to keep up with the user. > > Doing work every time the user changes the file is not always a good > thing.=20 It very much depends on the user's preferences. Note that in standard Emacs usage, font-lock runs after every character is typed. With the current ada-mode release, which uses partial parse instead of incremental parse, the parse process cannot keep up with user typing. So I run with jit-lock-defer-time set to 1.5 seconds. However, many people want the fontification to be much more responsive. With wisi incremental parse, ada-mode can now do that. Since I got incremental parse working in wisi, I've set jit-lock-defer-time to the default nil; I like it, and will not go back. I mostly tolerated the delay before because I knew how hard it would be to fix :). > Nowadays the user doesn't just expect automatic indentation, he wants > code formatting too, which means splitting, fusing and inserting > lines, plus moving chunks of code left and right. Doing that every > time a character is added or deleted can be visually confusing due to > chunks of text changing positions as you type, so the systems I know > are triggered by certain events (like the insertion of characters that > mark the end of statements).=20 Yes; different parser-based operations are triggered by different events. That is true for wisi now; font-lock is triggered by the standard Emacs mechanisms (ie, after every character is typed, the window is scrolled, etc), indent is triggered by the standard Emacs mechanisms (indent-region-function, indent-line-function; ie RET and TAB), navigate (computing single-file cross-reference) is triggered by forward-sexp or some similar "wisi-goto-*" function, reformatting is triggered by "align" (in parallel with the standard Emacs align mechanism) or a direct wisi-reformat-* function (there are some in a context menu for Ada). All of these operations update the parse tree only if the buffer has changed; if not, they use the existing tree. The user can always customize things - wisi provides the framework. > Then they analyze the code and, if it is well formed, apply the > reformatting. Something similar could be said about fontification and > other tasks. Wisi does indentation even in the presence of syntax errors (ie, not "well formed"). This helps when writing code; when entering an "if" statement, you don't have to start with a complete template; you just type the code. It does sometimes cause confusing results; fixing the syntax always resolves that. > So I'll insist on not obsessing too much about performance. Implement > something simple, see if it is usable. If not, invest effort on > optimizations until it is good enough. Yes; premature optimization is the enemy of good enough. And good benchmarks/metrics should be the guide of any optimization; allowing font-lock to run after every character is typed is one such metric. Indentation in the presence of syntax errors is another; that was the primary complaint about ada-mode before I implemented error correction, and is still a common complaint; incremental parse will improve that. These two metrics were the trigger that started me implementing incremental parse. --=20 -- Stephe