From: Juri Linkov <juri@linkov.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: Daniel Mendler <mail@daniel-mendler.de>, Ergus <spacibba@aol.com>,
Augusto Stoffel <arstoffel@gmail.com>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [External] : Re: Completions and history
Date: Wed, 13 Apr 2022 10:50:30 +0300 [thread overview]
Message-ID: <865yndxvzt.fsf@mail.linkov.net> (raw)
In-Reply-To: <SJ0PR10MB5488F90B3E31C42D0D28F18AF3ED9@SJ0PR10MB5488.namprd10.prod.outlook.com> (Drew Adams's message of "Tue, 12 Apr 2022 19:49:52 +0000")
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
>> Does Icicles support history completion in eshell and comint?
>
> Yes, I believe so.
>
> Command `icicle-comint-command':
>
> Retrieve a previously used command.
> Use this in a `comint-mode' buffer such as `*shell*' or
> `*inferior-lisp*'.
It seems `icicle-comint-command' does the same as
`comint-dynamic-list-input-ring' bound to `C-c C-l'.
Maybe the same key `C-c C-l' could be bound by default
in the minibuffer to enable history completion?
BTW, currently this command highlights the header line only partly.
Here is a fix to keep text properties by replace-match:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: comint-dynamic-list-input-ring.patch --]
[-- Type: text/x-diff, Size: 1085 bytes --]
diff --git a/lisp/comint.el b/lisp/comint.el
index 56082f622a..88eaf1120e 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -1110,7 +1110,8 @@ comint-dynamic-list-input-ring
(use-local-map keymap))
(forward-line 3)
(while (search-backward "completion" nil 'move)
- (replace-match "history reference")))
+ (replace-match (apply #'propertize "history reference"
+ (text-properties-at (point))))))
(sit-for 0)
(message "Hit space to flush")
(setq comint-dynamic-list-input-ring-window-conf conf)
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index f60af482da..a4a04fc4ec 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -1895,9 +1980,7 @@ completions-detailed
:version "28.1")
(defcustom completions-header-format
- (propertize "%s possible completions:\n"
- 'face 'shadow
- :help "Please select a completion")
+ (propertize "%s possible completions:\n" 'face 'shadow)
"Format of completions header.
It may contain one %s to show the total count of completions.
When nil, no header is shown."
next prev parent reply other threads:[~2022-04-13 7:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220411112901.kv3lsyvx6yxwjbph.ref@Ergus>
2022-04-11 11:29 ` Completions and history Ergus
2022-04-11 16:56 ` Juri Linkov
2022-04-11 17:40 ` Ergus
2022-04-12 16:20 ` Juri Linkov
2022-04-12 16:53 ` Ergus
2022-04-12 16:59 ` Ergus
2022-04-12 17:12 ` Juri Linkov
2022-04-12 17:35 ` Ergus
2022-04-12 18:10 ` Juri Linkov
2022-04-12 17:24 ` Augusto Stoffel
2022-04-12 17:50 ` [External] : " Drew Adams
2022-04-12 18:05 ` Juri Linkov
2022-04-12 19:49 ` Drew Adams
2022-04-13 7:50 ` Juri Linkov [this message]
2022-04-13 12:00 ` Augusto Stoffel
2022-04-13 12:12 ` Po Lu
2022-04-14 2:56 ` Richard Stallman
2022-04-13 16:40 ` Drew Adams
2022-04-13 17:58 ` Juri Linkov
2022-04-13 17:57 ` Juri Linkov
2022-04-13 15:49 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=865yndxvzt.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=arstoffel@gmail.com \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=mail@daniel-mendler.de \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).