Re: master d5f11e890c5: * Makefile.in (install-info): Fix target (bug#69569).

Re: master d5f11e890c5: * Makefile.in (install-info): Fix target (bug#69569).

[Po Lu]

Andrea Corallo <acorallo@gnu.org> writes:

> branch: master
> commit d5f11e890c598cd2e15cb2fd93e604ed100ce355
> Author: Vincenzo Pupillo <v.pupillo@gmail.com>
> Commit: Andrea Corallo <acorallo@gnu.org>
>
>     * Makefile.in (install-info): Fix target (bug#69569).
> ---
>  Makefile.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.in b/Makefile.in
> index d54583399d0..6f014909307 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -812,7 +812,7 @@ install-info: info
>  	      done; \
>  	     (cd "$${thisdir}"; \
>  	      ${INSTALL_INFO} --info-dir="$(DESTDIR)${infodir}" "$(DESTDIR)${infodir}/$$elt"); \
> -	      cp type_hierarchy* $(DESTDIR)${infodir}/; \ # Used by elisp.info.
> +	      cp type_hierarchy* $(DESTDIR)${infodir}/; \
>  	   done; \
>  	fi
>  

Wouldn't it be proper to attach a unique prefix to the names of these
files, in case Emacs is not the only program interested in distributing
a "type_hierarchy.jpg" with its manuals?

Re: master d5f11e890c5: * Makefile.in (install-info): Fix target (bug#69569).

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: Vincenzo Pupillo <v.pupillo@gmail.com>
> Date: Wed, 06 Mar 2024 09:35:59 +0800
> 
> Andrea Corallo <acorallo@gnu.org> writes:
> 
> > -	      cp type_hierarchy* $(DESTDIR)${infodir}/; \ # Used by elisp.info.
> > +	      cp type_hierarchy* $(DESTDIR)${infodir}/; \
> >  	   done; \
> >  	fi
> >  
> 
> Wouldn't it be proper to attach a unique prefix to the names of these
> files, in case Emacs is not the only program interested in distributing
> a "type_hierarchy.jpg" with its manuals?

Indeed, I think something like elisp_type_hierarchy.jpg should be a
better name.

Re: master d5f11e890c5: * Makefile.in (install-info): Fix target (bug#69569).

[Andrea Corallo]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Po Lu <luangruo@yahoo.com>
>> Cc: Vincenzo Pupillo <v.pupillo@gmail.com>
>> Date: Wed, 06 Mar 2024 09:35:59 +0800
>> 
>> Andrea Corallo <acorallo@gnu.org> writes:
>> 
>> > -	      cp type_hierarchy* $(DESTDIR)${infodir}/; \ # Used by elisp.info.
>> > +	      cp type_hierarchy* $(DESTDIR)${infodir}/; \
>> >  	   done; \
>> >  	fi
>> >  
>> 
>> Wouldn't it be proper to attach a unique prefix to the names of these
>> files, in case Emacs is not the only program interested in distributing
>> a "type_hierarchy.jpg" with its manuals?
>
> Indeed, I think something like elisp_type_hierarchy.jpg should be a
> better name.

SGTM will do.

  Andrea

Re: master d5f11e890c5: * Makefile.in (install-info): Fix target (bug#69569).

[Andrea Corallo]

Andrea Corallo <acorallo@gnu.org> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Po Lu <luangruo@yahoo.com>
>>> Cc: Vincenzo Pupillo <v.pupillo@gmail.com>
>>> Date: Wed, 06 Mar 2024 09:35:59 +0800
>>> 
>>> Andrea Corallo <acorallo@gnu.org> writes:
>>> 
>>> > -	      cp type_hierarchy* $(DESTDIR)${infodir}/; \ # Used by elisp.info.
>>> > +	      cp type_hierarchy* $(DESTDIR)${infodir}/; \
>>> >  	   done; \
>>> >  	fi
>>> >  
>>> 
>>> Wouldn't it be proper to attach a unique prefix to the names of these
>>> files, in case Emacs is not the only program interested in distributing
>>> a "type_hierarchy.jpg" with its manuals?
>>
>> Indeed, I think something like elisp_type_hierarchy.jpg should be a
>> better name.
>
> SGTM will do.

Should be done.

  Andrea