From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 431f8ff1e38: * lisp/imenu.el: Support more values for imenu-flatten (bug#70846) Date: Fri, 09 Aug 2024 20:43:22 +0300 Message-ID: <865xs9lhhh.fsf@gnu.org> References: <171558357066.26019.9766615061719600757@vcs2.savannah.gnu.org> <86bk572e6a.fsf@mail.linkov.net> <861q62pb8y.fsf@mail.linkov.net> <864jayjd8u.fsf@gnu.org> <86le49ymsl.fsf@mail.linkov.net> <86msoo4cf3.fsf@mail.linkov.net> <865xv9ugjx.fsf@mail.linkov.net> <867cffdsp8.fsf@mail.linkov.net> <86ttgs78eu.fsf@mail.linkov.net> <86msmj9adm.fsf@mail.linkov.net> <864j7wkf66.fsf@mail.linkov.net> <86zfpogu1v.fsf@mail.linkov.net> <86cymi2nc3.fsf@mail.linkov.net> <86ttfukw6e.fsf@gnu.org> <86frrdsn3q.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32484"; mail-complaints-to="usenet@ciao.gmane.io" Cc: me@eshelyaron.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 09 19:44:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1scTei-0008Fh-Mh for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Aug 2024 19:44:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1scTeC-0003S5-6P; Fri, 09 Aug 2024 13:43:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1scTeA-0003Q4-BU for emacs-devel@gnu.org; Fri, 09 Aug 2024 13:43:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1scTe9-0003d9-Ls; Fri, 09 Aug 2024 13:43:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xquTsu2x8/RL1E3GWNkT1jGODsvg5tDyFF9lsiEmxiA=; b=B3oZ7xILXFVl t2wiH24IQ+EG2PINpuuIWmBuMMnxmNr65IfnK4fikpP59d9sr9EpXAWgguC4qNxBpejy5DiSHO1Ur hGB7ruZPY9bs7NAFlMW8HSSs3vrd2IrZOqSks/CyLnOzf/K5Kjt2SChCNA1E1TcZ58UJ8EhRzIJbZ NsnBbHAROMzdDDoq82+FbA2e/SQizaaxPN0cZsszEM95LrV2ueo4G9NaD8GxosvMhn1oyqevHiXy1 /Ad4+GMC0beKzqn4OFByL3ofl3xPkAGZ+Y3DQC9FdaSQ2MKvA9oiKOro4b3glVaj+S7R6kN4zst85 QyeczcGYFm0CGuYykm3RrQ==; In-Reply-To: <86frrdsn3q.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 09 Aug 2024 19:10:09 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322582 Archived-At: > From: Juri Linkov > Cc: me@eshelyaron.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Fri, 09 Aug 2024 19:10:09 +0300 > > >> :type '(choice (const :tag "Show nested list" nil) > >> (const :tag "Flat list with sections as prefix" prefix) > >> + (const :tag "Flat list with sections as suffix" suffix) > >> + (const :tag "Flat list with reverse sections as suffix" suffix-reverse) > > > > "Reverse sections"? Can we make this tag text more clear? > > I have no idea. How about "Flat list, sections as suffix, in reverse order of sections." > Another problem is that the tag is too long. That usually means the option is over-engineered. > This will make it shorter: "Flat list with reverse suffix". I don't understand what us "reverse suffix". AFAIU, the "reverse" part refers to order, not to the suffixes. > An unclear tag is not a problem since it's explained in the docstring. I disagree. If an unclear tag would not be a problem, we could just make the tag be the name of the corresponding symbol.