Re: master 69ec333eab0: Allow customizing partial-completion to be more like substring

[Eli Zaretskii <eliz@gnu.org>]

Spencer, would you please take care of these gotchas?

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Spencer Baugh <sbaugh@janestreet.com>
> Date: Sat, 24 Aug 2024 12:15:49 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> Hi,
> 
> > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> > index 3beb3c06a18..6fae62b3904 100644
> > --- a/lisp/minibuffer.el
> > +++ b/lisp/minibuffer.el
> > @@ -1141,7 +1141,15 @@ and DOC describes the way this style of completion works.")
> >      ;; and simply add "bar" to the end of the result.
> >      emacs22)
> >    "List of completion styles to use.
> > -The available styles are listed in `completion-styles-alist'.
> > +An element should be a symbol which is listed in
> > +`completion-styles-alist'.
> > +
> > +An element can also be a list of the form
> > +(STYLE ((VARIABLE VALUE) ...))
> > +STYLE must be a symbol listed in `completion-styles-alist', followed by
> > +a `let'-style list of variable/value pairs.  VARIABLE will be bound to
> > +VALUE (without evaluating it) while the style is handling completion.
> > +This allows repeating the same style with different configurations.
> 
> The :type of completion-styles should be adapted in order to reflect
> this change. Furthermore, this warrants a change of the :version, I
> believe.
> 
> Just being curious: why must it be a form (STYLE ((VARIABLE VALUE) ...)) ?
> Wouldn't it be sufficient to use (STYLE (VARIABLE VALUE) ...) ?
> 
> > +(defcustom completion-pcm-leading-wildcard nil
> > +  "If non-nil, partial-completion completes as if there's a leading wildcard.
> > +
> > +If nil (the default), partial-completion requires a matching completion
> > +alternative to have the same beginning as the first \"word\" in the
> > +minibuffer text, where \"word\" is determined by
> > +`completion-pcm-word-delimiters'.
> > +
> > +If non-nil, partial-completion allows any string of characters to occur
> > +at the beginning of a completion alternative, as if a wildcard such as
> > +\"*\" was present at the beginning of the minibuffer text.  This makes
> > +partial-completion behave more like the substring completion style."
> > +  :version "30.1"
> > +  :type 'boolean)
> 
> This doesn't look right, it should be :version "31.1".
> 
> Best regards, Michael.
> 
>