From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: cannot understand Elisp manual node Glyphs Date: Thu, 08 Feb 2007 09:51:54 +0100 Message-ID: <864ppxhw0l.fsf@lola.quinscape.zz> References: <87y7n9ins4.fsf@catnip.gol.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1170924739 20096 80.91.229.12 (8 Feb 2007 08:52:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 8 Feb 2007 08:52:19 +0000 (UTC) Cc: Emacs-Devel , Drew Adams , Miles Bader To: storm@cua.dk (Kim F. Storm) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 08 09:52:16 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HF50o-0002Hr-Jv for ged-emacs-devel@m.gmane.org; Thu, 08 Feb 2007 09:52:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HF50o-0004QB-6i for ged-emacs-devel@m.gmane.org; Thu, 08 Feb 2007 03:52:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HF50a-0004Ox-5Q for emacs-devel@gnu.org; Thu, 08 Feb 2007 03:52:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HF50Z-0004Nc-F2 for emacs-devel@gnu.org; Thu, 08 Feb 2007 03:51:59 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HF50Z-0004NJ-8B for emacs-devel@gnu.org; Thu, 08 Feb 2007 03:51:59 -0500 Original-Received: from pc3.berlin.powerweb.de ([62.67.228.11]) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HF50Y-0004yz-M5 for emacs-devel@gnu.org; Thu, 08 Feb 2007 03:51:58 -0500 Original-Received: from quinscape.de (pd95b0fdb.dip0.t-ipconnect.de [217.91.15.219]) by pc3.berlin.powerweb.de (8.9.3p3/8.9.3) with ESMTP id JAA15271 for ; Thu, 8 Feb 2007 09:51:54 +0100 X-Delivered-To: Original-Received: (qmail 24373 invoked from network); 8 Feb 2007 08:51:54 -0000 Original-Received: from unknown (HELO lola.quinscape.zz) ([10.0.3.43]) (envelope-sender ) by ns.quinscape.de (qmail-ldap-1.03) with SMTP for ; 8 Feb 2007 08:51:54 -0000 Original-Received: by lola.quinscape.zz (Postfix, from userid 1001) id BBC5FC9952; Thu, 8 Feb 2007 09:51:54 +0100 (CET) In-Reply-To: (Kim F. Storm's message of "Thu\, 08 Feb 2007 09\:26\:11 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:66111 Archived-At: storm@cua.dk (Kim F. Storm) writes: > Miles Bader writes: > >> storm@cua.dk (Kim F. Storm) writes: >>> These functions are handy: >>> >>> (defun make-glyph-with-face (c face) >>> "Return a glyph code representing char C with face FACE." >>> (logior c (lsh (face-id face) 19))) >> >> Good idea, but why not just call it "make-glyph"...? > > Because Xemacs already has a function named make-glyph with > different semantics. > > But maybe we don't need to care about that? In my opinion, we really should. It is one thing if stuff fails with undefined functions when porting. It is another if stuff fails in mysterious ways (at best because of incompatible argument types). > Maybe the face arg should be optional, and we could use the > following names to avoid confusion: > > make-display-glyph (char &optional face) > display-glyph-face (glyph) > display-glyph-char (glyph) Well, picking from the doc string, make-glyph-code would seem a suitable choice, too. -- David Kastrup