unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* bug in handling of package-unsigned-archives
@ 2017-02-20 15:50 Andy Moreton
  2017-02-25 13:04 ` Andy Moreton
  2017-06-05 22:16 ` Dmitry Gutov
  0 siblings, 2 replies; 5+ messages in thread
From: Andy Moreton @ 2017-02-20 15:50 UTC (permalink / raw)
  To: emacs-devel


Consider the following package archive setup:

(setq package-archives '(("melpa" . "https://melpa.org/packages/")
                         ("gnu"   . "https://elpa.gnu.org/packages/")))
(setq package-check-signature   t)
(setq package-unsigned-archives '("melpa"))

Using "M-x list-packages" results in an error being reported: "Unsigned
file ‘archive-contents’ at https://melpa.org/packages/". This is caused
by an incorrect check in package.el - the following patch fixes it.

2017-02-20  Andy Moreton  <andrewjmoreton@gmail.com>

	Fix check for package-unsigned-archives during retrieval.

	* lisp/emacs-lisp/package.el (package--download-one-archive):
          Fix check for package-unsigned-archives.

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 6728f1b..13b8051 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1522,7 +1522,7 @@ package--download-one-archive
       (when (listp (read-from-string content))
         (make-directory dir t)
         (if (or (not package-check-signature)
-                (member archive package-unsigned-archives))
+                (member name package-unsigned-archives))
             ;; If we don't care about the signature, save the file and
             ;; we're done.
             (progn (write-region content nil local-file nil 'silent)




^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-06-05 22:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-20 15:50 bug in handling of package-unsigned-archives Andy Moreton
2017-02-25 13:04 ` Andy Moreton
2017-06-05 16:18   ` Richard Copley
2017-06-05 22:12     ` Dmitry Gutov
2017-06-05 22:16 ` Dmitry Gutov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).