From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Brinkhoff Newsgroups: gmane.emacs.devel Subject: Re: User-defined record types Date: Thu, 16 Mar 2017 21:03:57 +0100 Organization: nocrew Message-ID: <864lytvviq.fsf@molnjunk.nocrew.org> References: <87pokampa4.fsf@ericabrahamsen.net> <878tp0i74g.fsf@users.sourceforge.net> <87efyg6y0i.fsf_-_@drachen> <87zigwz9wx.fsf@tromey.com> <86bmtbd45s.fsf@molnjunk.nocrew.org> <86bmt42nk2.fsf_-_@molnjunk.nocrew.org> <86o9x40z35.fsf@molnjunk.nocrew.org> <86k27s0w6m.fsf@molnjunk.nocrew.org> <86fuif22o6.fsf@molnjunk.nocrew.org> <86a88mz9tx.fsf@molnjunk.nocrew.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489694983 15890 195.159.176.226 (16 Mar 2017 20:09:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 16 Mar 2017 20:09:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 16 21:09:40 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cobiL-0003cO-43 for ged-emacs-devel@m.gmane.org; Thu, 16 Mar 2017 21:09:37 +0100 Original-Received: from localhost ([::1]:45573 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cobiR-0007zj-4j for ged-emacs-devel@m.gmane.org; Thu, 16 Mar 2017 16:09:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cobdH-00041X-7B for emacs-devel@gnu.org; Thu, 16 Mar 2017 16:04:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cobdC-00046H-8j for emacs-devel@gnu.org; Thu, 16 Mar 2017 16:04:23 -0400 Original-Received: from [195.159.176.226] (port=48908 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cobdC-000469-2I for emacs-devel@gnu.org; Thu, 16 Mar 2017 16:04:18 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cobcw-00040t-1o for emacs-devel@gnu.org; Thu, 16 Mar 2017 21:04:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 16 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:7ToI5cuCxVlEaoMP+glhSkWB8+k= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213078 Archived-At: Stefan Monnier wrote: > OK, it's [now] working. A full bootstrap build still fails for me: cedet/ede.el:46:1:Error: Wrong type argument: sequencep, #%[cl-slot-descriptor expanded nil boolean ((:documentation . "State of an object being expanded in speedbar."))] > We're going to have trouble preserving backward compatibility with > pre-existing .elc files. As you can see, the code says it inherits > from `cl-structure-object' (which now is of `record` type), but its > constructor `make-sm-test` creates a vector rather than a record, so > (cl-typep 'cl-structure-object) will fail if it only considers > `type-of'. What if we relax the type check to use (aref object 0) instead? That works for both old and new instances, as long as :initial-offset is 0.