From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: fix for bug#29935 copyright-update inserts year at random places Date: Thu, 11 Jan 2018 10:48:14 -0600 Message-ID: <864lnstk8h.fsf@stephe-leake.org> References: <868tdh5fag.fsf@stephe-leake.org> <837et0ckou.fsf@gnu.org> <86shbm4ks9.fsf@stephe-leake.org> <86k1wy48ch.fsf@stephe-leake.org> <861sj54wox.fsf@stephe-leake.org> <5A524604.6070909@gmx.at> <5A533F7D.4090505@gmx.at> <86o9m4gug4.fsf@stephe-leake.org> <83po6k6uiy.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1515689229 1405 195.159.176.226 (11 Jan 2018 16:47:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 Jan 2018 16:47:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 11 17:47:05 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZg0L-0008Bt-F1 for ged-emacs-devel@m.gmane.org; Thu, 11 Jan 2018 17:47:01 +0100 Original-Received: from localhost ([::1]:55185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZg2L-0003Ak-3B for ged-emacs-devel@m.gmane.org; Thu, 11 Jan 2018 11:49:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZg1f-000388-G9 for emacs-devel@gnu.org; Thu, 11 Jan 2018 11:48:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZg1a-0000VQ-I5 for emacs-devel@gnu.org; Thu, 11 Jan 2018 11:48:23 -0500 Original-Received: from smtp113.ord1d.emailsrvr.com ([184.106.54.113]:37058) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eZg1a-0000UB-DA for emacs-devel@gnu.org; Thu, 11 Jan 2018 11:48:18 -0500 Original-Received: from smtp15.relay.ord1d.emailsrvr.com (localhost [127.0.0.1]) by smtp15.relay.ord1d.emailsrvr.com (SMTP Server) with ESMTP id 5F8FE60094 for ; Thu, 11 Jan 2018 11:48:16 -0500 (EST) X-Auth-ID: board-president@tomahawk-creek-hoa.com Original-Received: by smtp15.relay.ord1d.emailsrvr.com (Authenticated sender: board-president-AT-tomahawk-creek-hoa.com) with ESMTPSA id 253BA60075 for ; Thu, 11 Jan 2018 11:48:16 -0500 (EST) X-Sender-Id: board-president@tomahawk-creek-hoa.com Original-Received: from Takver4 (76-218-37-33.lightspeed.kscymo.sbcglobal.net [76.218.37.33]) (using TLSv1.2 with cipher AES256-GCM-SHA384) by 0.0.0.0:25 (trex/5.7.12); Thu, 11 Jan 2018 11:48:16 -0500 In-Reply-To: <83po6k6uiy.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 Jan 2018 21:05:25 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 184.106.54.113 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221841 Archived-At: Eli Zaretskii writes: >> From: Stephen Leake >> Date: Mon, 08 Jan 2018 10:56:59 -0600 >> >> This thread is nominally about patching emacs-26 to fix a bug. The patch >> I've posted is a minimal fix; adding code or redesigning to handle frames >> better is feature-creep, so it should be done on master. > > I think the bug happens because we use save-window-excursion, and > switch buffers inside it. The cure should be not to do what hurts. > Can this be done in this case? If not, why not? And why do we use > save-window-excursion in the first place? that's not the usual way to > display a buffer whose contents is referenced in an error message or a > prompt. I posted an update on debbugs, giving a recipe for reproducing the bug, and giving the results of various suggested fixes. I tried deleting save-window-excursion; that does not fix the bug. I don't have a rationale for the current design of the function, but I think redesigning it should be done on master, not emacs-26. -- -- Stephe