From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Tue, 27 Jul 2021 20:40:56 -0700 Message-ID: <864kcf5cmv.fsf_-_@stephe-leake.org> References: <83h7gw6pyj.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> <83k0li2shw.fsf@gnu.org> <86wnpg82v3.fsf@stephe-leake.org> <83lf5wyn0z.fsf@gnu.org> <86pmv66yqg.fsf@stephe-leake.org> <83a6maw705.fsf@gnu.org> <83r1fluikh.fsf@gnu.org> <88007ACB-31E5-440F-876D-9F43C8EE02CC@gmail.com> <86fsw05lom.fsf@stephe-leake.org> <8A3823DD-5D5A-4A33-8EF9-93F05497CE4C@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34799"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) Cc: Eli Zaretskii , =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel , monnier@iro.umontreal.ca, emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 28 05:41:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8aRx-0008rt-OP for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Jul 2021 05:41:42 +0200 Original-Received: from localhost ([::1]:51698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8aRv-0006JW-VT for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Jul 2021 23:41:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8aRO-0005dW-NO for emacs-devel@gnu.org; Tue, 27 Jul 2021 23:41:06 -0400 Original-Received: from gateway20.websitewelcome.com ([192.185.70.14]:44778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8aRK-0007D1-B3 for emacs-devel@gnu.org; Tue, 27 Jul 2021 23:41:06 -0400 Original-Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 6F9A2400D317D for ; Tue, 27 Jul 2021 22:24:58 -0500 (CDT) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id 8aRIm7vL2sCiy8aRImqy5j; Tue, 27 Jul 2021 22:41:00 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QH+pLzEtWHZ+UgsYWyuW9xmtKicHdkq7yzA5ULknSTI=; b=Uyn/ZCWXSj+Rurlh2SiB6kRv8k 2A1M6HgNkSHfgLeWnqR9Wd2BaSp5Fs/D3nMiYSrcoQwmUhbxOFkdQczjwhpRNz0P92JkNhxqXN+zp Y/MqE8cs6LVqTcoPFaQnOplnfJlJSqG6zMB4WXaXEJcnUeKtsnsjOtOXcds4J7g82pt8Xm6xIdVJc d1j0JDJ3+Zia0az9kIF3nH20IWirEu6WWisgsOQY9eil6aEgG5WS+Ap7/pNCkjeJ+a35sbrY/3ycq P5RlVukGMbJQa+PYTAdpjfDEFSTtBu491JM8yR0clGz/qxAW/1aCAgJePxduyZEozL8WSpIuBQwUu ULYuQ4pQ==; Original-Received: from [76.77.182.20] (port=49214 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m8aRH-001CRV-M5; Tue, 27 Jul 2021 21:40:59 -0600 In-Reply-To: <8A3823DD-5D5A-4A33-8EF9-93F05497CE4C@gmail.com> (Yuan Fu's message of "Tue, 27 Jul 2021 10:56:22 -0400") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1m8aRH-001CRV-M5 X-Source-Sender: (Takver4) [76.77.182.20]:49214 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 3 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: permerror client-ip=192.185.70.14; envelope-from=stephen_leake@stephe-leake.org; helo=gateway20.websitewelcome.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271718 Archived-At: Yuan Fu writes: >>>=20 >>> We need to =E2=80=9Cdelete=E2=80=9D the hidden text and =E2=80=9Cre-ins= ert=E2=80=9D when we widen the >>> buffer. I=E2=80=99ll try to make it a no-op as long as we remember to w= iden >>> before calling tree-sitter to parse anything. >>=20 >> First, the only thing TS deletes is tree nodes, not text; it does not >> have a copy of the buffer. >>=20 >> Why do you think we need to delete the tree nodes corresponding to the >> hidden text? They provide exactly the context needed to parse the >> visible text properly. > > I don=E2=80=99t think we need to, but I assume that tree-sitter will dele= te > the corresponding nodes if we hide the text from it.=20 No, tree-sitter only deletes nodes that cover changes. So don't send a change that deletes the hidden text; just send changes in the visible part of the text (that's the only place the user can make changes). tree-sitter will only run the scanner on the change regions, so it will only request text from the visible part of the buffer; all the requests will succeed. > For us, the text is there, just hidden; for tree-sitter, the text is > deleted. No, it simply won't notice that it can't access that part of the buffer, because it will never try. What, exactly, will the buffer-text fetch code do if tree-sitter violates the narrowing (by some error in tree-sitter or user code)? throw an exception? return a null string? --=20 -- Stephe