From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords Date: Fri, 15 Mar 2024 17:11:43 +0200 Message-ID: <864jd78r80.fsf@gnu.org> References: <86wmq39av4.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34640"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 15 16:12:27 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rl9ER-0008it-Fb for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Mar 2024 16:12:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rl9Dq-0003h7-RZ; Fri, 15 Mar 2024 11:11:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rl9Dp-0003gb-Bu for emacs-devel@gnu.org; Fri, 15 Mar 2024 11:11:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rl9Do-0008In-B7; Fri, 15 Mar 2024 11:11:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bfD4DniPoyFr5qNCsUnNV/JiwsnGLQ4ZcOTEjlm9n/I=; b=KoaxrpHmAzW/ wXEtejJJRCPu3TVY7fNCsLOmxOQKGn5vMBOiTrheupBtmYI00DqRa2vzp5HcUdzxCbJf2qyRh7xba RUyrmLIhER5bLtDSLwU/7VLDE7VUPlzsCnS4WZlR+dRaVLIva0gOsm2NgpRIe9ZorZ5RJrurPKvhJ OFt4wGz/0m75XAs4EIsLxB13gI9Y36dpZrXRnaQa+KLdAkJtaJc1dNycffw6CSD3UhGVge3Z2JB97 Y6pxHNBcLRYYhqXop+gMlQiSIppYAqB4p0eYA5QCJ667EocMKfeKXNbdn5a70y9cUwXpP2T0/7fki hWVi909VpR/AWokrz7fQ0A==; In-Reply-To: (message from Stefan Monnier on Fri, 15 Mar 2024 09:29:18 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317075 Archived-At: > From: Stefan Monnier > Cc: Michael Albinus , emacs-devel@gnu.org > Date: Fri, 15 Mar 2024 09:29:18 -0400 > > > The changes in the above commit cause the following warning when > > compiling simple.el: > > > > In read-passwd-toggle-visibility: > > simple.el:10880:18: Warning: reference to free variable `icon-preference' > > Does the patch below fix the problem? > [ I remember seeing the warning a few days ago, but can't reproduce it > right now. ] No, it makes things worse: In read-passwd-mode: simple.el:10907:16: Warning: reference to free variable `read-passwd--show-password-icon' simple.el:10912:12: Warning: reference to free variable `mode-line-faces' simple.el:10915:4: Error: `define-icon' defined after use in (define-icon read-passwd--hide-password-icon nil '((image "conceal.svg" "conceal.pbm" :height (0.8 . em)) (symbol " ") (text "<\\>")) "Mode line icon to hide a visible password." :group mode-line-faces :version "30.1" :help-echo "mouse-1: Toggle password visibility") (missing `require' of a library file?) simple.el:10915:16: Warning: reference to free variable `read-passwd--hide-password-icon' In end of data: simple.el:10907:4: Warning: the function `define-icon' might not be defined at runtime. simple.el:10883:19: Warning: the function `icon-string' might not be defined at runtime. Makefile:289: recipe for target `../lisp/simple.elc' failed