From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Flymake Support Indicator Errors in Margin Date: Sat, 16 Mar 2024 13:10:14 +0200 Message-ID: <864jd677qh.fsf@gnu.org> References: <87r0gfajlh.fsf@posteo.net> <868r2mtjdk.fsf@gnu.org> <86msr19ipu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10440"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com, philipk@posteo.net, emacs-devel@gnu.org To: Elijah G , Spencer Baugh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 16 12:10:57 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rlRwG-0002U0-Pc for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Mar 2024 12:10:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlRvi-0003LV-NM; Sat, 16 Mar 2024 07:10:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlRvh-0003Ji-0Q for emacs-devel@gnu.org; Sat, 16 Mar 2024 07:10:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlRvg-0000NV-Du; Sat, 16 Mar 2024 07:10:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=x6r/fdKF2Kw1qyrPd/DD+swfR8Wmavmp6s99BnVPgRY=; b=NESGiVARDcCyAWn2S5ct hRrKCQvBSoq3/hEPOLEejqmjhp9n6AnEjp2oQKw1KKoxvwTVL0yAkWMbg/Pdj7+uam31wJxqI0GSj 38Sbo/xb+vc0t9ghIlVtU72fI0t+oVOgkK+MTaDOFhdI/Z/7OcBzPhyptHUibN2qIgNlZig3qLaQI ReE2V1qaDXxlE9sLbx9CTCJnn5OpNzXX3+lvlqs0ra/qm/Q2EgYV+o55GdZpvNjV3R4KdjTiLO5ka rvaeIKAH59+yK6NSZk3hhE4fEoK6+92x868i1/n95Jq+vLrNRASXI55JMCpC96zvgTxSsDY9linud lKMH2uKQrY/Sbw==; In-Reply-To: (message from Elijah G on Thu, 14 Mar 2024 09:35:33 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317105 Archived-At: > From: Elijah G > Date: Thu, 14 Mar 2024 09:35:33 -0600 > Cc: João Távora , > philipk@posteo.net, emacs-devel@gnu.org > > On Thu, Mar 14, 2024 at 5:05 AM Eli Zaretskii wrote: > > > > +(defcustom flymake-margin-indicators-string > > > + `((error ,(if (char-displayable-p 8252) > > > + "‼" > > > + "!!") > > > + compilation-error) > > > > When do you expect this value to be evaluated? > > > > In general, I wonder whether it would be simpler and wiser to use just > > "!!", and leave it to users to customize to "‼" if their displays > > support that. (We can mention the possibility in the doc string.) > > I implemented it in a similar way to how display-fill-column-indicator > does with display-fill-column-indicator-character, this since I expect > users to only set left-margin-width to 1, because if there is several > errors on the same line, the indicators will be displayed next to each > other and it could be confusing. > > However I agree that it is better to change it to just "!!", > I fixed the patch and added a doc string for the possibility of including > non-ASCII characters. Spencer, any comments?