Re: [PATCH] Implement fast verisons of json-parse functions

[Eli Zaretskii <eliz@gnu.org>]

> From: Herman, Géza <geza.herman@gmail.com>
> Cc: Géza Herman <geza.herman@gmail.com>,
>  emacs-devel@gnu.org
> Date: Tue, 19 Mar 2024 20:50:48 +0100
> 
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > An optional feature I had in mind was conditional compilation, 
> > so that
> > users should decide at build time which version they want.  But 
> > the
> > names and signatures of the functions exposed to Lisp should be 
> > the
> > same in both cases, so that Lisp programmers don't need to 
> > change
> > their programs to cater to both alternatives.
> >
> > Apologies if what I wrote was not clear enough about that.  For 
> > the
> > future, I suggest that we discuss the practical implication of
> > significant changes before you go ahead and invest many hours in
> > implementing and testing them.  I would like to avoid situations 
> > where
> > you invest significant efforts based on misunderstandings.
> 
> Thank you for the great attitude!  No worries, it only took ~10 
> minutes to create that version.  And even if we don't want to have 
> that approach, it can still be useful for validation (comparing 
> the parsing results of the original and new parser) and 
> benchmarking purposes.
> 
> If we want to have conditional compilation, is there a simple 
> similar conditional compilation case already in Emacs?  So I can 
> copy the approach easily (supposedly I need to add a flag to 
> configure, it needs to add a -DUSE_OWN_JSON_PARSER switch to the 
> compiller, etc.)

Let's wait with this until we have a clear idea whether we need this.
My suggestion was just to present a possibility, not necessarily a
decision that we should have this.  I'm not sure yet whether we need
to offer the possibility of using libjansson for parsing JSON as an
option.