unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tassilo Horn <tsdh@gnu.org>
Cc: morgan@ice9.digital, emacs-devel@gnu.org, visuweshm@gmail.com
Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback)
Date: Mon, 23 Sep 2024 14:55:01 +0300	[thread overview]
Message-ID: <864j66h9ey.fsf@gnu.org> (raw)
In-Reply-To: <8734lqzx64.fsf@gnu.org> (message from Tassilo Horn on Mon, 23 Sep 2024 08:44:35 +0200)

> From: Tassilo Horn <tsdh@gnu.org>
> Cc: emacs-devel@gnu.org,  Eli Zaretskii <eliz@gnu.org>, visuweshm@gmail.com
> Date: Mon, 23 Sep 2024 08:44:35 +0200
> 
> Morgan Willcock <morgan@ice9.digital> writes:
> 
> > When looking at the SVG files in the location browsed by
> > doc-view-dired-cache I can see that the Azure invoice has:
> >
> > - A transparent background with black and grey text on it.
> > - A dark grey border with white text on it.
> > - A white border with black text on it.
> >
> > The transparent background is shown as white or black, depending on
> > whether the light or dark theme is loaded, but the text is always
> > readable because the text colour complements the background.
> >
> > The problem is the text that is not on the transparent area of the
> > document, presumably because a coloured border cannot be identified as
> > being part of the background and so the border colours will never
> > follow the theme.
> >
> > Based on my usage, setting doc-view-mupdf-use-svg to t seems to make
> > reading PDF documents significantly more difficult.
> >
> > Perhaps there should be an option to just assume a white background
> > and render using the original colours, and turn that on by default.
> 
> That's what Visuwesh's advice of setting doc-view-svg-face's
> foreground/background to black and white would do.  We could do that by
> default instead of inheriting from the default face (which is modified
> by the theme).  That would probably give sensible results in most cases.
> 
> I've also tried un-inheriting doc-view-svg-face from the default face so
> that it is the empty face, i.e., all its attributes are nil.  In that
> case, it looks exactly as if it inherited from the default face, i.e.,
> the document is styled according to the theme with the same problems for
> certain files as you see.
> 
> I've also created a PDF with blue background and different text colors.
> In that case, doc-view-svg-face set to "black on wide" doesn't seem to
> have any effect.  The foreground/background colors of the document
> appear exactly as I've specified them in the original LaTeX document and
> as the Evince or mupdf PDF viewer show them, too.
> 
> Eli, what do you think?

Sorry, I don't understand what you are asking me about.  Please
elaborate

It sounds like PDF documents with colors have inherent problems with
doc-view-mupdf-use-svg and/or themes, so maybe we should warn about
this in NEWS and in the doc string, and suggest that people either
customize the doc-view-svg-face, or disable doc-view-mupdf-use-svg.



  parent reply	other threads:[~2024-09-23 11:55 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 17:53 No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback) Morgan Willcock
2024-09-20 18:53 ` Eli Zaretskii
2024-09-20 19:34   ` Visuwesh
2024-09-20 19:39   ` Morgan Willcock
2024-09-20 22:29     ` chad
2024-09-20 22:46       ` Morgan Willcock
2024-09-21  8:09     ` Eli Zaretskii
2024-09-21  9:27       ` Morgan Willcock
2024-09-21 17:35         ` Tassilo Horn
2024-09-22 20:57           ` Morgan Willcock
2024-09-23  6:44             ` Tassilo Horn
2024-09-23  8:34               ` Manuel Giraud via Emacs development discussions.
2024-09-23  8:45                 ` Tassilo Horn
2024-09-23 11:34                   ` Manuel Giraud via Emacs development discussions.
2024-09-23 11:56                 ` Eli Zaretskii
2024-09-23 14:51                   ` Tassilo Horn
2024-09-23 15:35                     ` Eli Zaretskii
2024-09-23 15:50                       ` Morgan Willcock
2024-09-23 16:10                       ` Tassilo Horn
2024-09-23 16:27                         ` Eli Zaretskii
2024-09-23 16:54                           ` Tassilo Horn
2024-09-24 11:17                             ` Eli Zaretskii
2024-09-24 11:22                               ` Tassilo Horn
2024-09-23 17:56                         ` Manuel Giraud via Emacs development discussions.
2024-09-23 18:35                           ` Tassilo Horn
2024-09-23 19:06                             ` Manuel Giraud via Emacs development discussions.
2024-09-23  9:36               ` Visuwesh
2024-09-23 11:55               ` Eli Zaretskii [this message]
2024-09-23 12:05                 ` Tassilo Horn
2024-09-23 15:32                   ` Eli Zaretskii
2024-09-21  7:28   ` Tassilo Horn
2024-09-21  9:27     ` Morgan Willcock
2024-09-21 11:04       ` Visuwesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=864j66h9ey.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=morgan@ice9.digital \
    --cc=tsdh@gnu.org \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).