From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Bignum speedup patch causes crash at startup Date: Wed, 05 Sep 2018 01:09:52 +0100 Message-ID: <8636uo954f.fsf@gmail.com> References: <83tvn5xicp.fsf@gnu.org> <86lg8hf3dy.fsf@gmail.com> <8c20c37f-983b-08e6-177f-9223f33914fc@cs.ucla.edu> <87ftyorixx.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1536106089 12082 195.159.176.226 (5 Sep 2018 00:08:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Sep 2018 00:08:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 05 02:08:05 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxLMa-00030d-BB for ged-emacs-devel@m.gmane.org; Wed, 05 Sep 2018 02:08:04 +0200 Original-Received: from localhost ([::1]:53100 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxLOg-0003l8-KH for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2018 20:10:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxLOX-0003kd-T1 for emacs-devel@gnu.org; Tue, 04 Sep 2018 20:10:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxLOU-0006le-Lc for emacs-devel@gnu.org; Tue, 04 Sep 2018 20:10:05 -0400 Original-Received: from [195.159.176.226] (port=34904 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxLOU-0006jX-8u for emacs-devel@gnu.org; Tue, 04 Sep 2018 20:10:02 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fxLML-0002ep-Lc for emacs-devel@gnu.org; Wed, 05 Sep 2018 02:07:49 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 26 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:CerVDNi/YtB9MQTKOXA8QMY/iyk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229274 Archived-At: On Tue 04 Sep 2018, Tom Tromey wrote: >>>>>> "Paul" == Paul Eggert writes: > > Paul> Andy Moreton wrote: >>> Tom added support in commit fb26c9fd69 ("Make purecopy work for >>> bignums"), so if that causes problems then it may need to be revisited. > > Paul> That code is never used and it wouldn't hurt to remove it as per the > Paul> attached. I'll CC: Tom to see if he has an opinion. > > I added it because someone (Andy I think but this illness is affecting > my memory somewhat) asked for it. It seemed not impossible for > something to try to dump a bignum. But, if it isn't needed, then IMO > that's fine. I mentioned that support for dumping bignums would seems to be a useful feature, in the sense of not having arbitrary restrictions. Tom added code to support that (the commit mentioned above). Dumping of bignums is not currently required by any emacs code, but it should be supported unless there is some unreasonable difficulty in doing so. AndyM