From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: display-buffer-use-some-frame Date: Tue, 11 Dec 2018 11:31:19 -0800 Message-ID: <8636r3g8s8.fsf@stephe-leake.org> References: <5BD601F9.2010708@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1544556616 32096 195.159.176.226 (11 Dec 2018 19:30:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 11 Dec 2018 19:30:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 11 20:30:12 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWnjQ-0008F9-3a for ged-emacs-devel@m.gmane.org; Tue, 11 Dec 2018 20:30:12 +0100 Original-Received: from localhost ([::1]:41143 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWnlW-0008TD-O9 for ged-emacs-devel@m.gmane.org; Tue, 11 Dec 2018 14:32:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWnkc-00082G-Kp for emacs-devel@gnu.org; Tue, 11 Dec 2018 14:31:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWnkZ-0006pA-HE for emacs-devel@gnu.org; Tue, 11 Dec 2018 14:31:26 -0500 Original-Received: from smtp73.ord1d.emailsrvr.com ([184.106.54.73]:36052) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gWnkZ-0006oU-Cj for emacs-devel@gnu.org; Tue, 11 Dec 2018 14:31:23 -0500 Original-Received: from smtp2.relay.ord1d.emailsrvr.com (localhost [127.0.0.1]) by smtp2.relay.ord1d.emailsrvr.com (SMTP Server) with ESMTP id 301934014A for ; Tue, 11 Dec 2018 14:31:21 -0500 (EST) X-Auth-ID: board-president@tomahawk-creek-hoa.com Original-Received: by smtp2.relay.ord1d.emailsrvr.com (Authenticated sender: board-president-AT-tomahawk-creek-hoa.com) with ESMTPSA id BE0F740678 for ; Tue, 11 Dec 2018 14:31:20 -0500 (EST) X-Sender-Id: board-president@tomahawk-creek-hoa.com Original-Received: from Takver4 ([UNAVAILABLE]. [76.77.182.20]) (using TLSv1.2 with cipher AES256-GCM-SHA384) by 0.0.0.0:25 (trex/5.7.12); Tue, 11 Dec 2018 14:31:21 -0500 In-Reply-To: <5BD601F9.2010708@gmx.at> (martin rudalics's message of "Sun, 28 Oct 2018 19:37:45 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 184.106.54.73 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231760 Archived-At: Finally getting back to this. martin rudalics writes: > - The first sentence of the doc-string doesn't fit on a whole line. > > - The line > > (window (and frame (get-lru-window frame nil (cdr (assq 'inhibit-same-window alist)))))) > > is too long. I see you've fixed these, thanks. > - In the call > > (window--display-buffer > buffer window 'frame alist display-buffer-mark-dedicated) > > you should write 'reuse instead of 'frame. The latter means that a > new frame has been made but you just reuse an existing window. I > noticed this because I made the same error in (an undocumented part > of) 'display-buffer-in-child-frame'. I'll fix this after the test below. > Also, I wonder why you call > 'frame-first-window' here: > > (not (window-dedicated-p > (or > (get-lru-window frame) > (frame-first-window frame))))) I don't remember. I'll test for a while without it. -- -- Stephe