Re: display-buffer-use-some-frame

[Stephen Leake <stephen_leake@stephe-leake.org>]

Finally getting back to this.

martin rudalics <rudalics@gmx.at> writes:

> - The first sentence of the doc-string doesn't fit on a whole line.
>
> - The line
>
>          (window (and frame (get-lru-window frame nil (cdr (assq 'inhibit-same-window alist))))))
>
>   is too long.

I see you've fixed these, thanks.

> - In the call
>
>           (window--display-buffer
>            buffer window 'frame alist display-buffer-mark-dedicated)
>
>   you should write 'reuse instead of 'frame.  The latter means that a
>   new frame has been made but you just reuse an existing window.  I
>   noticed this because I made the same error in (an undocumented part
>   of) 'display-buffer-in-child-frame'.

I'll fix this after the test below.

> Also, I wonder why you call
> 'frame-first-window' here:
>
>                            (not (window-dedicated-p
>                                  (or
>                                   (get-lru-window frame)
>                                   (frame-first-window frame)))))

I don't remember. I'll test for a while without it.

-- 
-- Stephe