unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Problems with desktop.el after reecent local-mior-modes changes
Date: Fri, 12 Mar 2021 19:10:40 +0000	[thread overview]
Message-ID: <8635x09oi7.fsf@gmail.com> (raw)
In-Reply-To: 87wnudff65.fsf@gnus.org

On Fri 12 Mar 2021, Lars Ingebrigtsen wrote:

> Andy Moreton <andrewjmoreton@gmail.com> writes:
>
>>> Presumably the `override-global-mode` was compiled with Emacs-28, so
>>> when you use it with Emacs-27 you get into trouble.
>>
>> Thanks Stefan, that is indeed the problem: the reference was in
>> bind-key.elc. I must have updated the package recently while running
>> emacs built from master.
>>
>> Is there a general way to avoid this kind of problem ?
>> Perhaps I need to use separate elpa dirs for each emacs version.
>
> I think `define-minor-mode' could be more helpful here -- that is, it
> could check run-time whether the variables in question are bound.  This
> should fix this problem when moving between Emacs versions.
>
> I think I'll make that change to Emacs 28 now.

Thanks Lars, this seems to fix things without the need for any
workarounds.

I tested by reinstalling the bind-key package in emacs-28, and checking
that bind-key.elc has a reference to local-minor-modes. After that the
desktop restore works without complaint on emacs-27.

    AndyM




  reply	other threads:[~2021-03-12 19:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 20:59 Problems with desktop.el after reecent local-mior-modes changes Andy Moreton
2021-03-11 21:07 ` Lars Ingebrigtsen
2021-03-11 21:10   ` Lars Ingebrigtsen
2021-03-11 22:35     ` Andy Moreton
2021-03-11 22:42       ` Stefan Monnier
2021-03-11 23:03         ` Andy Moreton
2021-03-11 23:23           ` Lars Ingebrigtsen
2021-03-12 19:10             ` Andy Moreton [this message]
2021-03-12 20:39               ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8635x09oi7.fsf@gmail.com \
    --to=andrewjmoreton@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).