From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Thu, 01 Jun 2023 19:21:12 +0300 Organization: LINKOV.NET Message-ID: <86353b40hz.fsf@mail.linkov.net> References: <875y8nks9t.fsf@localhost> <87fs7c10cq.fsf@web.de> <87v8g79zoe.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5377"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Michael Heerdegen , emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 01 18:26:33 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4l8A-000177-Vz for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Jun 2023 18:26:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4l7X-0003QO-Un; Thu, 01 Jun 2023 12:25:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4l7L-0003Ld-8l for emacs-devel@gnu.org; Thu, 01 Jun 2023 12:25:39 -0400 Original-Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4l7I-0005y3-C1 for emacs-devel@gnu.org; Thu, 01 Jun 2023 12:25:38 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id C41C4C0007; Thu, 1 Jun 2023 16:25:31 +0000 (UTC) In-Reply-To: <87v8g79zoe.fsf@localhost> (Ihor Radchenko's message of "Thu, 01 Jun 2023 11:42:25 +0000") Received-SPF: pass client-ip=2001:4b98:dc4:8::226; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306523 Archived-At: >> (if (org-fold-core-get-folding-spec-property spec :isearch-open) >> (overlay-put o 'isearch-open-invisible #'delete-overlay) >> (overlay-put o 'isearch-open-invisible #'ignore) >> (overlay-put o 'isearch-open-invisible-temporary #'ignore)) >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> Can't you bind this to a function that does what you want? AFAIU it is >> called with two arguments - the overlay itself and a bool saying "open" >> (nil) or "re-hide" (non-nil). That should allow to not rely on any >> hooks to remove your helper overlays. Unless, maybe, not all of them >> are opened. Can that happen? > > I tried... But it is prohibited to remove overlays when isearch is > tracking them: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60399 If it helps, you could design a new property that will obsolete the deficient 'isearch-open-invisible-temporary'. For a few releases the old property should be supported, but then eventually it will simplify code in Org-mode.