Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64.

[Eli Zaretskii <eliz@gnu.org>]

> Date: Wed, 7 Feb 2024 22:13:01 -0800
> Cc: Stefan Kangas <stefankangas@gmail.com>, emacs-devel@gnu.org, eliz@gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
> 
> On 2/7/2024 7:34 PM, Po Lu wrote:
> > Jim Porter <jporterbugs@gmail.com> writes:
> > 
> >> I don't have a terribly strong opinion here of what number to use, but
> >> we should at least resolve the inconsistencies in CONTRIBUTE,
> >> .dir-locals.el, and build-aux/git-hooks/commit-msg.
> > 
> > commit-msg is fine as-is, but CONTRIBUTE should be fixed.

I'm not sure I understand what needs to be fixed in CONTRIBUTE.  If
that's fallout of the recent change of fill-column, then I'd expect
the author of that change to adjust CONTRIBUTE as needed.

> I think I understand now. I find the CONTRIBUTE explanation rather 
> confusing to be honest, since it introduces ChangeLog files, mentions 
> ChangeLog entries in that context (which I interpret as "one commit 
> message -> one ChangeLog entry"), and then later talks about ChangeLog 
> entries again, but in the context of the commit message (where I 
> interpret it to mean "one ChangeLog entry = one file/function changed"). 
> Only after reading this a few times in detail did I notice this distinction.

Please try to tell in more detail what confused you.  I don't want to
make any significant change in CONTRIBUTE, since the current text is
the result of many people reading it and commenting on its text.  So
I'd prefer to make the minimal required changes, not rewrite whole
passages anew.

AFAICS, the current text clearly explains what it means by "ChangeLog
entries" that are part of the commit log messages.  All of this text
is under the "Commit messages" heading, so it is all about commit log
messages, not about ChangeLog files (which we no longer maintain by
hand as part of documenting changes we install).  So I don't quite see
why you got confused by the text there; please elaborate.

> No worries if this doesn't get merged, or if people change my wording. I 
> just thought it would be helpful to show an example of what I'd find 
> clearer.

I'd prefer if you explained what is not clear in the current text.

Thanks.