From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master bf0aeaa0d7a: Re-enable displaying `han' characters on Android Date: Thu, 01 Aug 2024 08:52:18 +0300 Message-ID: <8634noyelp.fsf@gnu.org> References: <86h6c5y39e.fsf@gnu.org> <87plqtf6m0.fsf@yahoo.com> <87le1hf5ed.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15123"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 01 07:53:08 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sZOkO-0003ns-FP for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Aug 2024 07:53:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZOji-0007GT-BV; Thu, 01 Aug 2024 01:52:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZOjf-00074y-AS for emacs-devel@gnu.org; Thu, 01 Aug 2024 01:52:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZOjf-0006It-19; Thu, 01 Aug 2024 01:52:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dAFzzPyLf+jPZdHqK3tZdUDObN9cRVFLQ6C+u3hqeN4=; b=cY094Umx3yrz XnvdeEL883kX4l1fym1zqSgJPn2HMl0XKocjHzQlrHoEHGXkun08PBGSyTgPdFl6NtZrkAzLSUOOe vfv9mLdNwC30GUjcrIqUCLGPnc9C8C2Szft59c9JkrBOkpkmGV2vCJVxYuZzWWQAd/eZUkryyNanC 1aJrNBcqq9IK+xp80EPJ9uBhwYLh15WiTbDPjCoh9rUqigTuJUjO3idD/qZCOirCHAxW9Fo5x9zKG oEBjIyvDsTxX1tfiZ6LCsaNf4848/h8Tmk4/6vhy3yFe4k0XXqU5n4xFEYG5NMDAUOO1KyfpvGJRr X3m5Qt4rx7v2cNz+uPyb5Q==; In-Reply-To: <87le1hf5ed.fsf@yahoo.com> (message from Po Lu on Thu, 01 Aug 2024 08:33:46 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322246 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Thu, 01 Aug 2024 08:33:46 +0800 > > Po Lu writes: > > > It does affect other platforms, but I'm only in the habit of installing > > master regularly on Android. > > In the event, this was not completely accurate. I've specialized some > generic code to Android that was enabled for all systems by accident, > rendering this matter moot, as `script-representative-chars' should not > have been consulted on other systems at the outset. I don't understand the changes you installed. The comments and the log message don't tell enough, and you have again installed the changes before discussing them, although I explicitly asked you not to do that. I see the changes in fontset setup related to 'han', which make them specific to Android. But the representative characters _are_ used on other systems, at least on MS-Windows (and AFAIU on other systems as well: see ftfont.c and font.c). So why you again removed the SMP characters from the list is not clear to me; I think it's a mistake and tend to revert that part.