From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [scratch/igc] 985247b6bee crash on Linux, KDE, Wayland Date: Thu, 05 Sep 2024 16:31:28 +0300 Message-ID: <8634me447j.fsf@gnu.org> References: <8734mezkgo.fsf@gmail.com> <87plpis6ff.fsf@protonmail.com> <87bk124aip.fsf@gmail.com> <87h6aus5yz.fsf@protonmail.com> <87y1461frv.fsf@gmail.com> <864j6u47g4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8707"; mail-complaints-to="usenet@ciao.gmane.io" Cc: execvy@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 05 15:32:19 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smCax-00029R-HE for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Sep 2024 15:32:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smCaG-00083K-II; Thu, 05 Sep 2024 09:31:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smCaC-00082p-Cj for emacs-devel@gnu.org; Thu, 05 Sep 2024 09:31:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smCaB-00083D-Uf; Thu, 05 Sep 2024 09:31:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=rbOdawrwCWRn7eMoegtNLZjhSgwuiKifQKMGK8gBVBU=; b=b6/5+mt2MP9uUB22Nq0J PbRsBNEpQ0v+BMaoyey7o6BwJkAGfz7WVKZzoSSHiiXeuejWwVbpLxs1tpFozjZwRcQ28E/cJkSNB JG52pic8O96GJI9kkE64K6LeV1SvcgPMnLoBXfx4vV3+n+4ikT3hN5x2CgoHHBYTVRvXvL/QHWnf1 Jcu7dIlTiroxAYBn/uiiqSnFdsvYWbcryCLXRipUoB64rEBGKqVRytT3MLM3Ejv98/rXoBAGgOfda vcaHR9jUiCcRQp21PsUvApzxHEAQm/JAYcD3j/uAB+N9IVHHOV0e8vp50T7kLtmp7NBS0MuuRrp1+ xb0kJT/KYD89/g==; In-Reply-To: (message from Gerd =?utf-8?Q?M=C3=B6llmann?= on Thu, 05 Sep 2024 15:20:40 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323405 Archived-At: > From: Gerd Möllmann > Cc: Eval EXEC , pipcet@protonmail.com, emacs-devel@gnu.org > Date: Thu, 05 Sep 2024 15:20:40 +0200 > > >> #23 > >> No symbol table info available. > >> #24 0x0000000000692cd8 in fix_frame (f=0x7f5f87885498, ss=0x7ffe0290f6a8) at /home/exec/Projects/git.savannah.gnu.org/git/emacs/src/igc.c:2068 > > > > This segfault is here: > > > > if (!FRAME_INITIAL_P (f)) > > { > > /* This is typically stored in the display_info, e.g. > > ns_display_info. Check for being NULL anyway. */ > > Mouse_HLInfo *hlinfo = MOUSE_HL_INFO (f); <<<<<<<<<<<<<<<<<<<<<<< > > if (hlinfo) > > { > > IGC_FIX12_OBJ (ss, &hlinfo->mouse_face_window); > > IGC_FIX12_OBJ (ss, &hlinfo->mouse_face_overlay); > > IGC_FIX12_RAW (ss, &hlinfo->mouse_face_mouse_frame); > > } > > } > > > > This code was added just a few days ago. MOUSE_HL_INFO expands to: > > > > # define MOUSE_HL_INFO(F) \ > > (FRAME_WINDOW_P (F) \ > > ? &FRAME_DISPLAY_INFO(F)->mouse_highlight \ > > : &(F)->output_data.tty->display_info->mouse_highlight) > > > > So this looks like FRAME_DISPLAY_INFO(F) is not traced or something? > > Hm, sesms we have to check for FRAME_OUTPUT_DATA being null for window > frames. Why do you think so? Are we sure FRAME_OUTPUT_DATA is NULL in this case (as opposed to a pointer that cannot be dereferenced because it was moved)?