From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>, Andrea Corallo <acorallo@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Use (eval-when-compile 'treesit) to save us from writing declare-function forms
Date: Sun, 08 Dec 2024 09:20:06 +0200 [thread overview]
Message-ID: <8634iyhc9l.fsf@gnu.org> (raw)
In-Reply-To: <292D0D0F-AB88-49AB-86DD-A9B736DB00F7@gmail.com> (message from Yuan Fu on Sat, 7 Dec 2024 22:39:21 -0800)
> From: Yuan Fu <casouri@gmail.com>
> Date: Sat, 7 Dec 2024 22:39:21 -0800
> Cc: Eli Zaretskii <eliz@gnu.org>,
> emacs-devel@gnu.org
>
> > On Dec 7, 2024, at 5:47 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> >
> >>> Does that mean declare-function forms only affect the file it’s in?
> >>> Because if treesit.el has declare-function forms for all the treesit.c
> >>> functions, and c-ts-mode.el requires treesit.el, why do we need to have
> >>> declare-function forms in c-ts-mode.el?
> >> Seems like that. Stefan, am I missing something here?
> >
> > Yes, `declare-function` *should* follow the same principles as `(defvar
> > FOO)`, meaning that they are compiler directives not functions to
> > execute. They affect warnings only in the current lexical scope, and
> > requiring a file full of `(defvar FOO)` and `declare-function` will have
> > no effect at all.
> >
> > [ Side note regarding this *should*: it currently doesn't work quite as
> > well as `defvar` because its effect is always file-wide, whereas it
> > should be limited to the current scope. ]
>
> Defining a macro that contains the declare-function forms, and calling it in eval-when-compile forms seem to work (see patch), WDYT? The name (treesit-declare-c-functions) could be better, any ideas?
Looks a bit ugly, but maybe this is the best we can do.
Andrea, WDYT?
next prev parent reply other threads:[~2024-12-08 7:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 6:31 Use (eval-when-compile 'treesit) to save us from writing declare-function forms Yuan Fu
2024-12-03 8:30 ` Andrea Corallo
2024-12-04 18:21 ` Yuan Fu
2024-12-03 13:12 ` Eli Zaretskii
2024-12-04 18:19 ` Yuan Fu
2024-12-04 18:57 ` Eli Zaretskii
2024-12-05 6:25 ` Yuan Fu
2024-12-05 7:07 ` Eli Zaretskii
2024-12-07 1:12 ` Yuan Fu
2024-12-07 7:51 ` Eli Zaretskii
2024-12-07 13:47 ` Stefan Monnier
2024-12-08 6:39 ` Yuan Fu
2024-12-08 7:20 ` Eli Zaretskii [this message]
2024-12-08 15:27 ` Stefan Monnier
2024-12-09 1:37 ` Yuan Fu
2024-12-09 2:40 ` Stefan Monnier
2024-12-11 1:57 ` Dmitry Gutov
2024-12-08 16:01 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634iyhc9l.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acorallo@gnu.org \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).