From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: fix for bug#29935 copyright-update inserts year at random places Date: Thu, 04 Jan 2018 06:47:58 -0600 Message-ID: <861sj54wox.fsf@stephe-leake.org> References: <868tdh5fag.fsf@stephe-leake.org> <837et0ckou.fsf@gnu.org> <86shbm4ks9.fsf@stephe-leake.org> <86k1wy48ch.fsf@stephe-leake.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1515069980 23972 195.159.176.226 (4 Jan 2018 12:46:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 4 Jan 2018 12:46:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 04 13:46:16 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eX4uU-0005rE-6N for ged-emacs-devel@m.gmane.org; Thu, 04 Jan 2018 13:46:14 +0100 Original-Received: from localhost ([::1]:57291 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX4wT-0007MR-JL for ged-emacs-devel@m.gmane.org; Thu, 04 Jan 2018 07:48:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX4wK-0007LM-AH for emacs-devel@gnu.org; Thu, 04 Jan 2018 07:48:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eX4wF-0001bp-Vd for emacs-devel@gnu.org; Thu, 04 Jan 2018 07:48:08 -0500 Original-Received: from smtp145.ord.emailsrvr.com ([173.203.6.145]:58052) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eX4wF-0001ZO-Mu for emacs-devel@gnu.org; Thu, 04 Jan 2018 07:48:03 -0500 Original-Received: from smtp27.relay.ord1a.emailsrvr.com (localhost [127.0.0.1]) by smtp27.relay.ord1a.emailsrvr.com (SMTP Server) with ESMTP id EBFA5C015A for ; Thu, 4 Jan 2018 07:48:01 -0500 (EST) X-Auth-ID: board-president@tomahawk-creek-hoa.com Original-Received: by smtp27.relay.ord1a.emailsrvr.com (Authenticated sender: board-president-AT-tomahawk-creek-hoa.com) with ESMTPSA id AC504C0159 for ; Thu, 4 Jan 2018 07:48:01 -0500 (EST) X-Sender-Id: board-president@tomahawk-creek-hoa.com Original-Received: from Takver4 (76-218-37-33.lightspeed.kscymo.sbcglobal.net [76.218.37.33]) (using TLSv1.2 with cipher AES256-GCM-SHA384) by 0.0.0.0:587 (trex/5.7.12); Thu, 04 Jan 2018 07:48:01 -0500 In-Reply-To: (Stefan Monnier's message of "Thu, 04 Jan 2018 00:34:22 -0500") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 173.203.6.145 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221587 Archived-At: Stefan Monnier writes: >> I think there are still situations where pop-to-buffer-same-window can >> change the window configuration (if it is invoked from a dedicated >> window, for example), so save-window-excursion is still needed. > > In my config, pop-to-buffer-same-window will often/usually pop up a new > frame (unless the buffer is already displayed somewhere, in which case > it deiconifies and/or raises that frame), "so save-window-excursion is > still needed^H^H^H^H^H^H^ineffective". > > This said, I actually do like that the buffer is shown in its > own frame. So using pop-to-buffer-same-window, rather than pop-to-buffer, is ok for you. > It would be nice to re-iconify the frame afterwards, tho. Apparently completion (or maybe read-from-minibuffer) does re-iconify a popped up frame (that happened once in my experiments). I looked thru the C code for read-from-minibuffer, and it has comments that talk about preserving the frame state, but I did not see where it minimizes the frame on return. So I don't know how to do that from elisp in copyright-update-year. -- -- Stephe