From: Stephen Leake <stephen_leake@stephe-leake.org>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Re: fix for bug#29935 copyright-update inserts year at random places
Date: Thu, 04 Jan 2018 06:47:58 -0600 [thread overview]
Message-ID: <861sj54wox.fsf@stephe-leake.org> (raw)
In-Reply-To: <jwvy3le2ntx.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Thu, 04 Jan 2018 00:34:22 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I think there are still situations where pop-to-buffer-same-window can
>> change the window configuration (if it is invoked from a dedicated
>> window, for example), so save-window-excursion is still needed.
>
> In my config, pop-to-buffer-same-window will often/usually pop up a new
> frame (unless the buffer is already displayed somewhere, in which case
> it deiconifies and/or raises that frame), "so save-window-excursion is
> still needed^H^H^H^H^H^H^ineffective".
>
> This said, I actually do like that the buffer is shown in its
> own frame.
So using pop-to-buffer-same-window, rather than pop-to-buffer, is ok for you.
> It would be nice to re-iconify the frame afterwards, tho.
Apparently completion (or maybe read-from-minibuffer) does re-iconify a
popped up frame (that happened once in my experiments). I looked thru
the C code for read-from-minibuffer, and it has comments that talk about
preserving the frame state, but I did not see where it minimizes the
frame on return. So I don't know how to do that from elisp in
copyright-update-year.
--
-- Stephe
next prev parent reply other threads:[~2018-01-04 12:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 23:29 fix for bug#29935 copyright-update inserts year at random places Stephen Leake
2018-01-02 9:21 ` Lele Gaifax
2018-01-02 16:03 ` Eli Zaretskii
2018-01-03 22:52 ` Stephen Leake
2018-01-04 1:01 ` Stefan Monnier
2018-01-04 3:21 ` Stephen Leake
2018-01-04 5:34 ` Stefan Monnier
2018-01-04 12:47 ` Stephen Leake [this message]
2018-01-04 18:23 ` Stefan Monnier
2018-01-07 16:08 ` martin rudalics
2018-01-07 17:34 ` Stefan Monnier
2018-01-08 9:53 ` martin rudalics
2018-01-08 13:15 ` Stefan Monnier
2018-01-08 16:56 ` Stephen Leake
2018-01-08 18:37 ` martin rudalics
2018-01-08 19:05 ` Eli Zaretskii
2018-01-11 16:48 ` Stephen Leake
2018-01-08 18:18 ` martin rudalics
2018-01-08 22:18 ` Stefan Monnier
2018-01-09 9:42 ` martin rudalics
2018-01-09 13:07 ` Stefan Monnier
2018-01-10 10:19 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861sj54wox.fsf@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).