From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Problems with desktop.el after reecent local-mior-modes changes Date: Thu, 11 Mar 2021 22:35:41 +0000 Message-ID: <861rclxqrm.fsf@gmail.com> References: <86pn05z9t4.fsf@gmail.com> <875z1xh00h.fsf@gnus.org> <871rclgzw3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13623"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) To: emacs-devel@gnu.org Cancel-Lock: sha1:eCfCwKCMnufT5Npp7hXYbon/4AU= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 11 23:36:43 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKTv9-0003SF-HK for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Mar 2021 23:36:43 +0100 Original-Received: from localhost ([::1]:42152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKTv8-0005LZ-Jj for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Mar 2021 17:36:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKTuL-0004Zm-Om for emacs-devel@gnu.org; Thu, 11 Mar 2021 17:35:54 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:58168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKTuI-0004My-Hz for emacs-devel@gnu.org; Thu, 11 Mar 2021 17:35:52 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lKTuG-0002DK-OC for emacs-devel@gnu.org; Thu, 11 Mar 2021 23:35:48 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266368 Archived-At: On Thu 11 Mar 2021, Lars Ingebrigtsen wrote: > Lars Ingebrigtsen writes: > >> Andy Moreton writes: >> >>> After updating master today (to commit 1d4195856b), I find that emacs >>> built from the emacs-27 branch fails to restore a desktop save file, and >>> complains that `local-minor-modes' is not defined as a variable. >> >> Say "make bootstrap". > > Sorry, I didn't read that closely enough. Is this error in Emacs 27, > when trying to restore a desktop save file made with Emacs 28? Yes. The odd thing is that local-minor-modes does not exist in emacs-27 and is not mentioned in the desktop save file. > Can you (setq debug-on-error t)? That'll give you a backtrace that'll > tell you where it's bugging out. Having bootstrapped emacs-27 from a clean tree, I see: Debugger entered--Lisp error: (void-variable local-minor-modes) override-global-mode(1) desktop-create-buffer(208 "~/.emacs.d/init.el" "init.el" emacs-lisp-mode (eldoc-mode override-global-mode) 26985 (27333 nil) nil nil ((show-trailing-whitespace . t) (buffer-display-time 24650 38542 784259 0) (buffer-file-coding-system . utf-8-unix)) ((mark-ring (27060 27332 27249 27205 27300 27205 27174 27060 27332 27332 27332 27332 27251 25536 25536 26985)))) eval-buffer(# nil "c:/home/ajm/.emacs.d/desktop/.ntemacs.desktop" nil t) ; Reading at buffer position 28147 load-with-code-conversion("c:/home/ajm/.emacs.d/desktop/.ntemacs.desktop" "c:/home/ajm/.emacs.d/desktop/.ntemacs.desktop" t t) load("c:/home/ajm/.emacs.d/desktop/.ntemacs.desktop" t t t) desktop-read() #f(compiled-function () #)() run-hooks(after-init-hook delayed-warnings-hook) command-line() normal-top-level() The `override-global-mode' minor mode is from the "bind-key" package, a dependency of "use-package" (both from MELPA). After some more experimentation, it seems that this is another workaround: (add-to-list 'desktop-minor-mode-handlers '(override-global-mode . ignore)) It is not obvious what is referring to `local-minor-modes' in this setup. AndyM