From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juan =?utf-8?Q?Jos=C3=A9_Garc=C3=ADa-Ripoll?= Newsgroups: gmane.emacs.devel Subject: Re: Error in project-shell? Date: Wed, 16 Mar 2022 16:15:36 +0100 Message-ID: <861qz2vsh3.fsf@csic.es> References: <86tucj82d0.fsf@csic.es> <865yown5sg.fsf@csic.es> <7fc361d6-2df4-aa2a-4f02-1ae1e03ebb6a@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30752"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (windows-nt) To: emacs-devel@gnu.org Cancel-Lock: sha1:o8Z/pwQCyj9+sQq27ehaNnz92ow= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 16 16:16:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUVOG-0007m7-UP for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Mar 2022 16:16:44 +0100 Original-Received: from localhost ([::1]:36464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUVOF-0008O3-Qx for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Mar 2022 11:16:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUVNL-0006t5-1i for emacs-devel@gnu.org; Wed, 16 Mar 2022 11:15:50 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:52508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUVNI-0007CR-Lr for emacs-devel@gnu.org; Wed, 16 Mar 2022 11:15:45 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nUVNG-0006Ru-0Q for emacs-devel@gnu.org; Wed, 16 Mar 2022 16:15:42 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287232 Archived-At: I have been doing further tests and I think that the actual definition should read as follows (defun project-shell-fix () "Fixed version for project-shell" (interactive) (require 'comint) (let* ((default-directory (expand-file-name (project-root (project-current t)))) (default-project-shell-name (project-prefixed-buffer-name "shell")) (shell-buffer (get-buffer default-project-shell-name))) (if (comint-check-proc shell-buffer) (pop-to-buffer shell-buffer (bound-and-true-p display-comint-buffer-action)) (shell (or shell-buffer default-project-shell-name))))) The change in the last line is needed, because otherwise the shell is created with the wrong name. -- Juan José García Ripoll http://juanjose.garciaripoll.com http://quinfog.hbar.es