From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers Date: Sun, 01 May 2022 21:06:46 +0300 Organization: LINKOV.NET Message-ID: <861qxdf7pl.fsf@mail.linkov.net> References: <87k0b84tfr.fsf@occasionallycogent.com> <87h76c4ruf.fsf@occasionallycogent.com> <86sfpwwerz.fsf@mail.linkov.net> <87czh03xa9.fsf@occasionallycogent.com> <87o80i3frf.fsf@occasionallycogent.com> <87ee1e374d.fsf@occasionallycogent.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11101"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Stefan Monnier , emacs-devel@gnu.org To: James N. V. Cash Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 01 20:09:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlE0w-0002jW-I3 for ged-emacs-devel@m.gmane-mx.org; Sun, 01 May 2022 20:09:46 +0200 Original-Received: from localhost ([::1]:41534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nlE0v-00028M-DM for ged-emacs-devel@m.gmane-mx.org; Sun, 01 May 2022 14:09:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlDzU-0000H2-Jw for emacs-devel@gnu.org; Sun, 01 May 2022 14:08:16 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:55151) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlDzT-0008Am-2S for emacs-devel@gnu.org; Sun, 01 May 2022 14:08:16 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id DA004240002; Sun, 1 May 2022 18:08:11 +0000 (UTC) In-Reply-To: <87ee1e374d.fsf@occasionallycogent.com> (James N. V. Cash's message of "Sat, 30 Apr 2022 11:48:02 -0400") Received-SPF: pass client-ip=217.70.183.193; envelope-from=juri@linkov.net; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289077 Archived-At: > Upon further inspection, I see that `minibuffer-completion-help` is setting > `completion-list-insert-choice-function` to a function that checks if the `beg` > and `end` arguments are strings, in which case it just replaces the > minibuffer contents with "beg" + "choice" + "end". Indeed, when doing > `completing-read` instead of `completing-read-multiple`, > `completion--replace` doesn't get called at all in this case. completing-read-multiple already overrides choose-completion-string-functions with own crm--choose-completion-string. So it would also make sense to override completion-list-insert-choice-function as well.