From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add support for `ch' and `cw' dimension specifiers for the image Date: Fri, 29 Mar 2024 13:52:10 +0300 Message-ID: <861q7tfgyt.fsf@gnu.org> References: <86sf0j1q0c.fsf@gnu.org> <86cyrehdre.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27081"; mail-complaints-to="usenet@ciao.gmane.io" Cc: alan@idiocy.org, lg.zevlg@gmail.com, emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 29 11:52:33 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rq9qa-0006nd-W9 for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Mar 2024 11:52:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rq9qK-0003he-QT; Fri, 29 Mar 2024 06:52:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rq9qI-0003fs-Lc for emacs-devel@gnu.org; Fri, 29 Mar 2024 06:52:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rq9qH-0002bv-Go; Fri, 29 Mar 2024 06:52:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=PTTSoe73neDSqoT7mVOjyqICAi3PjME5YGhnhNmAtEk=; b=BONEIlf12jaa5Nkvo5wG fKs8ftkCC4IjBPW5mm9W706IDQH9FePu291BXoSw62yJs3+Uz/RYzVxXDQP2yYgKsplZBpyTsDg3T cyJBHWKrBH7bk4hXGlrURLlvleqoEcQAMY1BQYLs4mqIrhpu7NjPu3WvLNTtm4lBZLE0CKtmEhGTT fgLo4ukTbgyqciHrmJuquTSVWnXMix4nyBOc07Lfgco8crKQfFIHTaKiC71PcYdeNGAzXD/BoPWzc mIElfu0yx5JqoehtKrbXRSbrkbprRL7W/lbtrHy3B7BXtq3+rCuih0oEh1iybIGueeeoNXDCSpURq jRbkE0pTL8dwMQ==; In-Reply-To: (message from Alan Third on Fri, 29 Mar 2024 09:50:06 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317378 Archived-At: > Date: Fri, 29 Mar 2024 09:50:06 +0000 > From: Alan Third > Cc: Eli Zaretskii , emacs-devel@gnu.org > > On Thu, Mar 28, 2024 at 10:34:32PM +0300, Evgeny Zajcev wrote: > > чт, 28 мар. 2024 г. в 14:41, Alan Third : > > > > > On Thu, Mar 28, 2024 at 01:50:37PM +0300, Evgeny Zajcev wrote: > > > > Yes, this is intentional, because saying "height of the font" in docs, > > > when > > > > font's pixel size is used in code, is misleading and it took me some time > > > > to understand why image renders smaller then font height if '(1 . em) is > > > > specified as dimension modifier. That's why I started using coefficient > > > > (calculated with `my-em-height-ratio') to `em' specifier > > > > > > Does this mean we have em wrong? It should ideally, IMO, be equivalent > > > to em in a web browser because that seems the most common use Emacs > > > users will be aware of. If we're using the wrong value then we should > > > change it. > > > > > > > Not wrong, but different. > > OK, I understand, thanks. Em should be equivalent to the font's size > (i.e. 12 points for a 12 point font) so it's good. This is different. > > I'm happy with it if you are, Eli. Yes, I'm okay with that as well. Thanks.