From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: [DISCUSSION] "quick-help" popup for org-columns (column view) Date: Mon, 08 Apr 2024 14:46:24 +0300 Message-ID: <861q7gyt4f.fsf@gnu.org> References: <87a5oayblv.fsf@gmail.com> <87jzlxro68.fsf@localhost> <87zfu6b4w3.fsf@gmail.com> <86jzl91zrd.fsf@gnu.org> <87frvwl2wv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39218"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, emacs-orgmode@gnu.org, emacs-devel@gnu.org, philipk@posteo.net, stefankangas@gmail.com, larsi@gnus.org, hmelman@gmail.com, info@protesilaos.com To: =?utf-8?Q?S=C5=82awomir?= Grochowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 08 13:47:25 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rtnTA-0009t5-EF for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Apr 2024 13:47:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtnSV-0000Tb-T8; Mon, 08 Apr 2024 07:46:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtnSH-0000TF-RP; Mon, 08 Apr 2024 07:46:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtnSF-0000l2-ST; Mon, 08 Apr 2024 07:46:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=oMTbSrdhoOEZSF4dVY6ZTo7kc6RVefoXMaNJdoMXOZI=; b=WRY3UOhsDnOywzs7dolJ ixpunfKvUSBvGxdNaojQ9M342C6e5prwBlGc/FtrUkG7Ya7+lvqzoYk3ynl+VrKmam2ZvmuOCXPEw 829MODTs6ewHGyL0nbO9MfPk93TPF3xBg2olIaV4uVH1PQeSH6AVV6f1t80BG6XT7SLgtz4LqKXEY Cg+Rou3DkNGmrixI6mGlz75gd19j/c0eGdi48IVN8mleqDkecYNgZh9Fr8+G5MM8RvedcJYncxoZQ NGreIF/RQHT+2+VSKWMqc7iR4USkqTlalGaN1Go43WxNrpARK+JV9LnGbsJgQdDOaqX8Uz0Bnvf9D /r/oKZZy8azD3g==; In-Reply-To: <87frvwl2wv.fsf@gmail.com> (message from =?utf-8?Q?S=C5=82awo?= =?utf-8?Q?mir?= Grochowski on Mon, 08 Apr 2024 09:38:40 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317604 gmane.emacs.orgmode:160918 Archived-At: > From: Sławomir Grochowski > Cc: yantar92@posteo.net, emacs-orgmode@gnu.org, emacs-devel@gnu.org, > philipk@posteo.net, stefankangas@gmail.com, larsi@gnus.org, > hmelman@gmail.com, info@protesilaos.com > Date: Mon, 08 Apr 2024 09:38:40 +0200 > > > The idea here was that some other function could rebind > > `help-quick-sections' dynamically. That way you avoid the redundant > > arguments (which would all have to be documented). > > Is this really a good practice? > Relying on global variables instead of passing variables as a parameters? Emacs is full of such practices, so don't worry about that, it's quite common (and considered good practice) in Emacs Lisp. > Eli Zaretskii writes: > > In any case, we cannot change the signature of help-quick, since it's a > > public function. > > If I can't modify the function `help-quick' how can I make it work? You write a new function with the signature you like and make help-quick call it to do the actual job. Where you want to use the signature of the new function, you call it directly.