Re: master 45f6cfb89e2: Merge remote-tracking branch 'origin/scratch/emacs-editorconfig'

Re: master 45f6cfb89e2: Merge remote-tracking branch 'origin/scratch/emacs-editorconfig'

[Michael Albinus]

Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:

Hi Stefan,

> diff --git a/doc/emacs/custom.texi b/doc/emacs/custom.texi
> index 6bf4cbe00df..6c33eb2019e 100644
> --- a/doc/emacs/custom.texi
> +++ b/doc/emacs/custom.texi
> @@ -1550,6 +1550,44 @@ variables are handled in the same way as unsafe file-local variables
>  do not visit a file directly but perform work within a directory, such
>  as Dired buffers (@pxref{Dired}).
>
> +@node EditorConfig support
> +@subsubsection Per-Directory Variables via EditorConfig
> +@cindex EditorConfig support
> +
> +The EditorConfig standard is an alternative to the @file{.dir-locals.el}
> +files, which can control only a very small number of variables, but
> +has the advantage of being editor-neutral.  Those settings are stored in
> +files named @file{.editorconfig}.

Sorry, I'm late to the party. Shouldn't we give a reference like
<https://spec.editorconfig.org/>?

Best regards, Michael.

Re: master 45f6cfb89e2: Merge remote-tracking branch 'origin/scratch/emacs-editorconfig'

[Robert Pluim]

>>>>> On Fri, 21 Jun 2024 16:24:56 +0200, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
    Michael> writes:

    Michael> Hi Stefan,

    >> diff --git a/doc/emacs/custom.texi b/doc/emacs/custom.texi
    >> index 6bf4cbe00df..6c33eb2019e 100644
    >> --- a/doc/emacs/custom.texi
    >> +++ b/doc/emacs/custom.texi
    >> @@ -1550,6 +1550,44 @@ variables are handled in the same way as unsafe file-local variables
    >> do not visit a file directly but perform work within a directory, such
    >> as Dired buffers (@pxref{Dired}).
    >> 
    >> +@node EditorConfig support
    >> +@subsubsection Per-Directory Variables via EditorConfig
    >> +@cindex EditorConfig support
    >> +
    >> +The EditorConfig standard is an alternative to the @file{.dir-locals.el}
    >> +files, which can control only a very small number of variables, but
    >> +has the advantage of being editor-neutral.  Those settings are stored in
    >> +files named @file{.editorconfig}.

    Michael> Sorry, I'm late to the party. Shouldn't we give a reference like
    Michael> <https://spec.editorconfig.org/>?

Also:

  GEN      ../../info/emacs.info
custom.texi:1553: warning: node `EditorConfig support' unreferenced

Robert
-- 

Re: master 45f6cfb89e2: Merge remote-tracking branch 'origin/scratch/emacs-editorconfig'

[Stefan Monnier]

>     Michael> Sorry, I'm late to the party. Shouldn't we give a reference like
>     Michael> <https://spec.editorconfig.org/>?

Indeed, thanks.  I added a ref to https://editorconfig.org/ (I think the
spec is more relevant for the coder than for the user).

>   GEN      ../../info/emacs.info
> custom.texi:1553: warning: node `EditorConfig support' unreferenced

Hmm... weird.  I don't see this on my machine.
Can someone better versed in Texinfo explain what's going on (or even
better fix the issue)?


        Stefan

Re: master 45f6cfb89e2: Merge remote-tracking branch 'origin/scratch/emacs-editorconfig'

[Robert Pluim]

>>>>> On Fri, 21 Jun 2024 10:41:24 -0400, Stefan Monnier <monnier@iro.umontreal.ca> said:

    Michael> Sorry, I'm late to the party. Shouldn't we give a reference like
    Michael> <https://spec.editorconfig.org/>?

    Stefan> Indeed, thanks.  I added a ref to https://editorconfig.org/ (I think the
    Stefan> spec is more relevant for the coder than for the user).

    >> GEN      ../../info/emacs.info
    >> custom.texi:1553: warning: node `EditorConfig support' unreferenced

    Stefan> Hmm... weird.  I don't see this on my machine.
    Stefan> Can someone better versed in Texinfo explain what's going on (or even
    Stefan> better fix the issue)?

(Iʼm using texinfo 6.8)

Iʼd expect to see an entry in an @menu somewhere for the node. If you
tell use where you think it should go, I can add it.

Robert
-- 

Re: master 45f6cfb89e2: Merge remote-tracking branch 'origin/scratch/emacs-editorconfig'

[Robert Pluim]

>>>>> On Fri, 21 Jun 2024 16:54:46 +0200, Robert Pluim <rpluim@gmail.com> said:

    Robert> (Iʼm using texinfo 6.8)

    Robert> Iʼd expect to see an entry in an @menu somewhere for the node. If you
    Robert> tell use where you think it should go, I can add it.

Actually, the resulting info file has an automatically generated menu
at the end of "Per-Directory Local Variables" pointing at the new
node, so maybe itʼs a warning thatʼs been fixed in a later version.

I guess we could add a menu there to get rid of the warning.

Robert
-- 

Re: master 45f6cfb89e2: Merge remote-tracking branch 'origin/scratch/emacs-editorconfig'

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org,  Michael Albinus <michael.albinus@gmx.de>
> Date: Fri, 21 Jun 2024 16:59:18 +0200
> 
> >>>>> On Fri, 21 Jun 2024 16:54:46 +0200, Robert Pluim <rpluim@gmail.com> said:
> 
>     Robert> (Iʼm using texinfo 6.8)
> 
>     Robert> Iʼd expect to see an entry in an @menu somewhere for the node. If you
>     Robert> tell use where you think it should go, I can add it.
> 
> Actually, the resulting info file has an automatically generated menu
> at the end of "Per-Directory Local Variables" pointing at the new
> node, so maybe itʼs a warning thatʼs been fixed in a later version.
> 
> I guess we could add a menu there to get rid of the warning.

Please just fix all the problems.  There's no need to discuss such
trivia.

Re: master 45f6cfb89e2: Merge remote-tracking branch 'origin/scratch/emacs-editorconfig'

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Fri, 21 Jun 2024 16:24:56 +0200
> 
> Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
> writes:
> 
> Hi Stefan,
> 
> > diff --git a/doc/emacs/custom.texi b/doc/emacs/custom.texi
> > index 6bf4cbe00df..6c33eb2019e 100644
> > --- a/doc/emacs/custom.texi
> > +++ b/doc/emacs/custom.texi
> > @@ -1550,6 +1550,44 @@ variables are handled in the same way as unsafe file-local variables
> >  do not visit a file directly but perform work within a directory, such
> >  as Dired buffers (@pxref{Dired}).
> >
> > +@node EditorConfig support
> > +@subsubsection Per-Directory Variables via EditorConfig
> > +@cindex EditorConfig support
> > +
> > +The EditorConfig standard is an alternative to the @file{.dir-locals.el}
> > +files, which can control only a very small number of variables, but
> > +has the advantage of being editor-neutral.  Those settings are stored in
> > +files named @file{.editorconfig}.
> 
> Sorry, I'm late to the party. Shouldn't we give a reference like
> <https://spec.editorconfig.org/>?

Yes, please add that, and thanks.

Re: master 45f6cfb89e2: Merge remote-tracking branch 'origin/scratch/emacs-editorconfig'

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org,  Michael Albinus <michael.albinus@gmx.de>
> Date: Fri, 21 Jun 2024 16:59:18 +0200
> 
> >>>>> On Fri, 21 Jun 2024 16:54:46 +0200, Robert Pluim <rpluim@gmail.com> said:
> 
>     Robert> (Iʼm using texinfo 6.8)
> 
>     Robert> Iʼd expect to see an entry in an @menu somewhere for the node. If you
>     Robert> tell use where you think it should go, I can add it.
> 
> Actually, the resulting info file has an automatically generated menu
> at the end of "Per-Directory Local Variables" pointing at the new
> node, so maybe itʼs a warning thatʼs been fixed in a later version.
> 
> I guess we could add a menu there to get rid of the warning.

Yes, we don't rely on automatic generation of menus in latest version
of Texinfo, at least not yet.

Re: master 45f6cfb89e2: Merge remote-tracking branch 'origin/scratch/emacs-editorconfig'

[Stefan Monnier]

> Yes, we don't rely on automatic generation of menus in latest version
> of Texinfo, at least not yet.

I just added the menu, thanks.


        Stefan

Re: master 45f6cfb89e2: Merge remote-tracking branch 'origin/scratch/emacs-editorconfig'

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Robert Pluim <rpluim@gmail.com>,  emacs-devel@gnu.org,
>   michael.albinus@gmx.de
> Date: Fri, 21 Jun 2024 15:56:06 -0400
> 
> > Yes, we don't rely on automatic generation of menus in latest version
> > of Texinfo, at least not yet.
> 
> I just added the menu, thanks.

Thanks, but the @detailmenu in emacs.texi should also be updated with
the new node(s).  I did that now.