From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 8c81818673a 6/7: Tune volatile in read_char Date: Mon, 19 Aug 2024 18:44:27 +0300 Message-ID: <861q2ky0tg.fsf@gnu.org> References: <172386820621.30556.15409337288904485218@vcs2.savannah.gnu.org> <20240817041648.A6687C2BC66@vcs2.savannah.gnu.org> <87f24fac-aa71-499f-a398-2bad70a0ca42@cs.ucla.edu> <8634n0y2th.fsf@gnu.org> <87plq4cyuj.fsf@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5203"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acorallo@gnu.org, eggert@cs.ucla.edu, emacs-devel@gnu.org, stefankangas@gmail.com To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 19 17:45:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sg4ZN-0001AG-RK for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Aug 2024 17:45:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sg4Yc-0002E9-6f; Mon, 19 Aug 2024 11:44:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sg4Ya-0002Dk-9g for emacs-devel@gnu.org; Mon, 19 Aug 2024 11:44:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sg4YY-0003uA-Nc; Mon, 19 Aug 2024 11:44:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=P+PwrkdZfxoGAQXCS2XNAIGqZXlZPKiuB9m1B1snOwA=; b=fueMRTGqLZbs v6Bx2//2a6HU8+p1oL2NbQ+u6d2FrYIkRmZq9/1fUt6IGUn+3F2zK4licaN9cxbJBdrMyETQjE9oR MyvjsfaIGLQ5LNOMcEdgmDN0VG1/cu3V7WkdQgRtpcylcOsqwsXsC1E6SS89s1lvqacKcnmTMWv9F P+KUz6dO/F5QmOayiowdPTj+i4E5SA6DGDeQ3SY26wzQ0RP4ey10F5X42hjJjph5mFwtGAcXs9eOb 3VcDIdF8OBs9UbBzYFgyDsyWILv9lzPAidPwrkvn8yeqLyDLBBy9R/FUen3RPen4OnIVzEUL6HWVD r7Ovmr3Bw5PrfLHlnd7mqg==; In-Reply-To: <87plq4cyuj.fsf@protonmail.com> (message from Pip Cet on Mon, 19 Aug 2024 15:32:40 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322934 Archived-At: > Date: Mon, 19 Aug 2024 15:32:40 +0000 > From: Pip Cet > Cc: Andrea Corallo , eggert@cs.ucla.edu, emacs-devel@gnu.org, stefankangas@gmail.com > > "Eli Zaretskii" writes: > > >> Don't know what the other maintainers think about this but FWIW I don't > >> like this change (and similar ones). Our codebase is already > >> sufficiently tricky and convoluted, complexifying code for no observable > >> improvements should be IMO out of our goals. > > > > I tend to agree. Especially given that the rationale for this > > juggling and why exactly we assign and re-assign these two variables > > in those particular places is nowhere to be found, neither in the > > source code nor in the commit log message. > > Could we measure the performance impact of making all stack variables in > functions that call setjmp() volatile? Why would that be useful? (Many/most of them already are volatile.) In any case, this is not what this thread is about, so let's not mix together unrelated issues.