From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: Win64 testers? Date: Thu, 22 Aug 2024 21:34:37 +0300 Message-ID: <861q2gs8xu.fsf@gnu.org> References: <87bk1k8mzd.fsf@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25972"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sebastian@sebasmonia.com, kien.n.quang@gmail.com, emacs-devel@gnu.org, yantar92@posteo.net To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 22 20:35:26 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shCeb-0006da-7K for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Aug 2024 20:35:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shCdv-0005pu-QT; Thu, 22 Aug 2024 14:34:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shCdt-0005pS-SO for emacs-devel@gnu.org; Thu, 22 Aug 2024 14:34:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shCdt-0001Mt-FU; Thu, 22 Aug 2024 14:34:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CjYv7EQLDMWS/Ghou4ob1QpJVsJD0AMleM1QRSDoOFs=; b=RaNoOvaHbiaq qYxgOcUkqUO1lQPa0OkiAIbmxZR/ZwLGzCJ9MITKovaEaHYBZ93CZe4YHaXH9V6gZQsNP5lJ6ReVA 3XIja5Df0uG3yFzE1lTHXvq2NT7xGtP6p5oWWPVxXEZ3UOShr0QvaayQr5V2eRv2fLxrJIGFlMjED u+eQ0Y17yDST00K5XmoPS8PhkawtaSsrpGsri1+8/tKUzYamTmX3pymtekw/4xgKqvZMSqoVZ012h iKN3r5yNPpIh1AdAmNylRugB5MqzseueRfmYVSEOobc0xKzZuqU6Me4VmJWCFT6+xOLNt2RMmbDEn L9cCp/13ktsbtrs7+JtOkA==; In-Reply-To: <87bk1k8mzd.fsf@protonmail.com> (message from Pip Cet on Thu, 22 Aug 2024 17:51:38 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323054 Archived-At: > Date: Thu, 22 Aug 2024 17:51:38 +0000 > From: Pip Cet > Cc: Quang Kien Nguyen , Eli Zaretskii , emacs-devel@gnu.org, Ihor Radchenko > > > I was running this version today: > > > > https://github.com/kiennq/emacs-build/releases/tag/v31.305.20240819.4794ea5 > > > > Had two different crashes, hope that these backtraces are more useful > > (thanks again to Pip and Ihor for their help) > > Thank you, that's very useful. Indeed, it looks like the > Windows-specific code hands off a pointer to MPS-managed memory to > GNUTLS to use as a cookie, while other OSes use an FD number cast to an > intptr_t cast to void *. You are talking about this line in emacs_gnutls_pull: emacs_gnutls_transport_set_errno (process->gnutls_state, errno == EWOULDBLOCK ? EAGAIN : errno); which causes us to call GnuTLS thusly: gnutls_transport_set_errno (state, err); is that right? Does this mean we will have to audit all our calls to external libraries and make sure we never pass to them any part of any Lisp object? That's a tough requirement; it's very easy to miss some such use, which then triggers segfaults. Am I missing something? Btw, I tried using EWW in my MinGW MPS build, and it didn't crash. Is it possible to have a reproducible recipe for this?