From: Eli Zaretskii <eliz@gnu.org>
To: Andrea Corallo <acorallo@gnu.org>
Cc: pipcet@protonmail.com, emacs-devel@gnu.org
Subject: Re: __builtin_expect
Date: Fri, 29 Nov 2024 09:19:55 +0200 [thread overview]
Message-ID: <861pyucxr8.fsf@gnu.org> (raw)
In-Reply-To: <yp1o71zgi3a.fsf@fencepost.gnu.org> (message from Andrea Corallo on Thu, 28 Nov 2024 16:32:25 -0500)
> From: Andrea Corallo <acorallo@gnu.org>
> Cc: Emacs Devel <emacs-devel@gnu.org>
> Date: Thu, 28 Nov 2024 16:32:25 -0500
>
> > You said that your assumption holds "when we are not compiling", but your code change applies to the other case, too.
>
> Indeed, but Emacs is rarely compiling, Emacs is not primary a compiler,
> and I hope it's clear that we want to optimize for its everyday typical
> use. Given in that case 'syms_with_pos_enabled' is simply false all the
> time, this is just the way to express that to the compiler so it can
> generate the right code.
I agree.
> Actually AFAIU/R the presence of 'syms_with_pos_enabled' there *is* an
> optimization to mitigate the performance impact of this feature on the
> most common Emacs usecase (the one my patch optimized further).
Right.
prev parent reply other threads:[~2024-11-29 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 15:45 __builtin_expect (was: Re: master b0ba0d42b0f: * src/lisp.h (EQ): Improve generated code.) Pip Cet via Emacs development discussions.
2024-11-28 16:12 ` __builtin_expect Andrea Corallo
2024-11-28 20:29 ` __builtin_expect Pip Cet via Emacs development discussions.
2024-11-28 21:32 ` __builtin_expect Andrea Corallo
2024-11-28 22:06 ` __builtin_expect Pip Cet via Emacs development discussions.
2024-11-29 7:19 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861pyucxr8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acorallo@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=pipcet@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).