From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: message-mode toolbars, was: Re: "Why is emacs so square?" Date: Fri, 1 May 2020 01:44:38 +0300 Message-ID: <860266fc-7a9e-35fa-1795-bd4088dc8cf1@yandex.ru> References: <8wXYP4GY9hwW-9mYv6_LGMETZ8Vz3Ob1Bec6yh6kPT7yxjTkxA3V6dXY4ELra9tYiJUxJmgXKSIEX4w8HFiPRoeGVSQHDSoBVy1voj1e3Qo=@protonmail.com> <83imhzecc5.fsf@gnu.org> <83y2qvcjv6.fsf@gnu.org> <83k12ed20s.fsf@gnu.org> <83blnqctyj.fsf@gnu.org> <9341072a-cf53-9092-2211-aa97c946e5b1@yandex.ru> <838sinfygb.fsf@gnu.org> <16fad982-e95b-7df1-25d0-1c666a6f8120@gmail.com> <83tv1begq5.fsf@gnu.org> <279c7ae5-b6c4-827b-393f-9ab34fbda81a@yandex.ru> <87v9lh38f1.fsf@gnus.org> <87bln8zkjh.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="61875"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= , Eli Zaretskii , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 01 00:46:10 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUHwX-000FzB-O7 for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 00:46:09 +0200 Original-Received: from localhost ([::1]:53984 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUHwW-0007KS-IP for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Apr 2020 18:46:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59472) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUHvM-0006c5-Oo for emacs-devel@gnu.org; Thu, 30 Apr 2020 18:44:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUHvI-000573-S4 for emacs-devel@gnu.org; Thu, 30 Apr 2020 18:44:54 -0400 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:45068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUHvA-0004x3-DF; Thu, 30 Apr 2020 18:44:49 -0400 Original-Received: by mail-wr1-x431.google.com with SMTP id o27so4055214wra.12; Thu, 30 Apr 2020 15:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VNQf047qxArBQGg+ra7pNz/CD9egR+yw5iiq/seHnXw=; b=pzAaSJgFTY88Ru3C9O4CXG5yuY9KH523n8pvV7DYnC0/7ZaVUUky0BjpC/c9ZD9Mli vvFCy+dkynoQIGkZ2IaW+Fn47GzmkGWZJ1HCMx0GhGDCDzmap4oXyeGl4jjjY0X0YVMy eGMK4+eOpJnpcd4U+r/HlL5haoYct0OiDaztyN5LidHtL3rUQz5xC/lTUD77UbmQ4gFR gvUeAZJ7Yn1xjAlXbLJLAeVvs8BQenEXtIO9nLBJD+9vMdpkrdP3CcmerSE7HbiaZ3Ki 4O30jMg/TvKN2yseousigWKBBTukmUdmmbZENoEBbQy8351c3zs/sVL1WTIsCIbzW8yM IzSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VNQf047qxArBQGg+ra7pNz/CD9egR+yw5iiq/seHnXw=; b=Tj1a2lQspANLkU84bRF5+j02du+yeqmqDtjaF0kjOzpUh6thI+IzQH3yHfbym0p0Z9 vINPxkJLUKMjcwaY7sp4H4cIToN5/Zae+NO55wXZAEqITGu6cKopdS0yDVUDonIE42mU 0l/nMs8ADCERBJ42SpKT6XFrleZ9W8G2ZfdbGkXtwPpfC0kWiqrIpzp6Ud9A8XjnNpMa rm7uRbIJwP9qPDqT166tQH2vCJ5hw3/mkggJK+5+JXqaB5LPJ3TDLn20vyuF3YYlx0ec +H+2xTRj4le/tCXpzVNdVpF+WmJ1AY2lssUO5wiRpMVn73SPTwa3DB7o8Qfs8qEneXsX v5RQ== X-Gm-Message-State: AGi0PubNWXlHWa6yyj1nirlgZu4yWFp4EnjUZg0YpYR4DTGaBJJWcJNT fo7TTUn6YmjjxIvz6TBB0BluKxe2S2U= X-Google-Smtp-Source: APiQypJZQNtVedRdhojID6HCh+iGlr7tyhjGnEyiZqbFapzI2/OtVfNivS3pLcsU+DGx3N0w+bAeTQ== X-Received: by 2002:adf:ed0e:: with SMTP id a14mr846957wro.400.1588286680906; Thu, 30 Apr 2020 15:44:40 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id j11sm1605812wrr.62.2020.04.30.15.44.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2020 15:44:39 -0700 (PDT) In-Reply-To: <87bln8zkjh.fsf@gnus.org> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=raaahh@gmail.com; helo=mail-wr1-x431.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2a00:1450:4864:20::431 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248280 Archived-At: On 01.05.2020 01:16, Lars Ingebrigtsen wrote: > Oh, it's this bit? > > (defcustom gmm-tool-bar-style > (if (and (boundp 'tool-bar-mode) > tool-bar-mode > - (and (fboundp 'display-visual-class) > - (not (memq (display-visual-class) > - (list 'static-gray 'gray-scale > - 'static-color 'pseudo-color))))) > + (memq (display-visual-class) > + (list 'static-gray 'gray-scale > + 'static-color 'pseudo-color))) > 'gnome > 'retro) > > Oops. Looks like I removed the `not' by mistake while I was cleaning up > the foundp test somehow? Yup. > That's clearly a regression and should be fixed on the emacs-27 branch, > I think. This breakage is from 2016, so it most likely got into Emacs 25. More importantly, while I'm all for fixing bugs, I think fixing it now will be more risky than my icons patch, because gmm-tool-bar-style affects which toolbar is shown. And for message-mode, at least, the 'gnome' and 'retro' toolbars have different contents.