unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Brinkhoff <lars@nocrew.org>
Cc: emacs-devel@gnu.org
Subject: Re: Incorrect indentation after :name
Date: Tue, 05 Jul 2005 21:44:33 +0200	[thread overview]
Message-ID: <85vf3pt4v2.fsf@junk.nocrew.org> (raw)
In-Reply-To: <E1Dpspa-0007EC-Hb@fencepost.gnu.org> (Richard M. Stallman's message of "Tue, 05 Jul 2005 15:11:42 -0400")

"Richard M. Stallman" <rms@gnu.org> writes:
>     Somewhat related to this, I have a patch to improve indentation of
>     macros that are defined with defmacro* and uses &body.  The macro must
>     be loaded for my code to do its job.
>
> Could we manage to make this work without loading the macro?
> Perhaps by providing another place to find the information?

The code works by checking the position of &body inside the macro
argument list, and setting the lisp-indent-function property of the
macro name to that number.

This is the gist of the patch:

Index: lisp/emacs-lisp/cl-macs.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/emacs-lisp/cl-macs.el,v
retrieving revision 1.53
diff -u -F^(def -r1.53 cl-macs.el
--- lisp/emacs-lisp/cl-macs.el	4 Jul 2005 17:33:35 -0000	1.53
+++ lisp/emacs-lisp/cl-macs.el	5 Jul 2005 19:37:39 -0000
@@ -202,8 +202,15 @@ (defmacro defmacro* (name args &rest bod
 
 \(fn NAME ARGLIST [DOCSTRING] BODY...)"
   (let* ((res (cl-transform-lambda (cons args body) name))
-	 (form (list* 'defmacro name (cdr res))))
-    (if (car res) (list 'progn (car res) form) form)))
+	 (form `((defmacro ,name ,@(cdr res)))))
+    (if (memq '&body args)
+	(push `(put ',name 'lisp-indent-function ,(position '&body args))
+	      form))
+    (if (car res)
+	(push (car res) form))
+    (if (cdr form)
+	(cons 'progn form)
+	(car form))))
 
 (defmacro function* (func)
   "Introduce a function.

  reply	other threads:[~2005-07-05 19:44 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-03 15:59 Incorrect indentation after :name Lennart Borgman
2005-07-03 16:39 ` Juanma Barranquero
2005-07-03 16:52   ` Lennart Borgman
2005-07-03 17:16     ` Juanma Barranquero
2005-07-03 22:29       ` Drew Adams
2005-07-03 22:44         ` Juanma Barranquero
2005-07-03 17:10   ` Luc Teirlinck
2005-07-04 14:48 ` Stefan Monnier
2005-07-04 21:22   ` David Ponce
2005-07-05  0:40   ` Juanma Barranquero
2005-07-05  4:35   ` Richard M. Stallman
2005-07-05  5:21     ` Stefan Monnier
2005-07-05  7:07       ` Lars Brinkhoff
2005-07-05 19:11         ` Richard M. Stallman
2005-07-05 19:44           ` Lars Brinkhoff [this message]
2005-07-07  5:36             ` Richard M. Stallman
2005-07-07  8:25               ` Lars Brinkhoff
2005-07-08  4:35                 ` Richard M. Stallman
2005-07-05 13:49       ` Drew Adams
2005-07-05 16:09         ` Paul Pogonyshev
2005-07-05 19:11       ` Richard M. Stallman
2005-07-06  0:20         ` Luc Teirlinck
2005-07-06  1:29           ` drkm
2005-07-06  1:43             ` Luc Teirlinck
2005-07-06 17:55           ` Richard M. Stallman
2005-07-06 18:30             ` David Kastrup
2005-07-07  3:09               ` Stefan Monnier
2005-07-07 17:01                 ` Drew Adams
2005-07-07 17:49                   ` Lawrence Mitchell
2005-07-07 18:35                     ` Drew Adams
2005-07-07 21:47                       ` Lawrence Mitchell
2005-07-07 22:21                         ` Drew Adams
2005-07-07 18:49                     ` Juanma Barranquero
2005-07-08  4:36                       ` Richard M. Stallman
2005-07-11  9:29                         ` Juanma Barranquero
2005-07-11 10:59                           ` David Kastrup
2005-07-11 13:00                             ` Juanma Barranquero
2005-07-07 21:30                 ` Richard M. Stallman
2005-07-07  5:36               ` Richard M. Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85vf3pt4v2.fsf@junk.nocrew.org \
    --to=lars@nocrew.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).