From: Wolfgang Jenkner <wjenkner@inode.at>
To: Vitalie Spinu <spinuvit@gmail.com>
Cc: Stefan Monnier <monnier@IRO.UMontreal.CA>,
joakim@verona.se, emacs-devel@gnu.org
Subject: Re: image-transform.el and image-mode.el rewrite
Date: Fri, 19 Jul 2013 13:52:16 +0200 [thread overview]
Message-ID: <85vc463gy7.fsf@inode.at> (raw)
In-Reply-To: <87ehavihbp.fsf_-_@gmail.com> (Vitalie Spinu's message of "Fri, 19 Jul 2013 01:22:50 +0200")
On Fri, Jul 19 2013, Vitalie Spinu wrote:
> +;; these are 3, virtuly unchenged, objects from old image-mode.el
> +;; fixme: see the author
Hi!
> + ;; on GNU Emacs 24.3.50.4 (i686-pc-linux-gnu, X toolkit, Xaw
> + ;; scroll bars) of 2013-07-16, image width is slightly
> + ;; truncated, ~6px, so the below mambo math for .5px
> + ;; adjustment is pretty useless.
The rotation stuff is written in such a a way that fit-width
(resp. fit-height) produces a rotated image whose bounding-box, with the
roundings applied by ImageMagick, viz.
> +;; geometry.x = (ssize_t) floor(min.x-0.5);
> +;; geometry.y = (ssize_t) floor(min.y-0.5);
> +;; geometry.width=(size_t) ceil(max.x-geometry.x+0.5);
> +;; geometry.height=(size_t) ceil(max.y-geometry.y+0.5);
has _exactly_ the desired pixel width (resp. height), and there's an
assertion in image-mode which tests this.
So, except for this
> +(defvar image--right-angle-fudge 0.0001
> + "Snap distance to a multiple of a right angle.
> +There's no deep theory behind the default value, it should just
> +be somewhat larger than ImageMagick's MagickEpsilon.")
everything is exact math without fudge factors.
In particular, thing's won't be quite correct if you do
> + ;; VS[16-07-2013]: returning (w . h) is unnecessary, it
> + ;; distorts the image and processing becomes very slow
Wolfgang
next prev parent reply other threads:[~2013-07-19 11:52 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 7:25 imagemagic in image-mode and image-dired-thumbnail-mode? Vitalie Spinu
2013-07-14 8:32 ` joakim
2013-07-14 11:48 ` Vitalie Spinu
2013-07-14 12:40 ` joakim
2013-07-14 13:01 ` Vitalie Spinu
2013-07-14 12:42 ` Lars Magne Ingebrigtsen
2013-07-14 18:21 ` Glenn Morris
2013-07-14 19:50 ` Lars Magne Ingebrigtsen
2013-07-14 20:06 ` Eli Zaretskii
2013-07-14 20:11 ` Lars Magne Ingebrigtsen
2013-07-14 22:00 ` Vitalie Spinu
2013-07-15 4:38 ` Eli Zaretskii
2013-07-15 4:15 ` Stephen J. Turnbull
2013-07-15 4:46 ` Eli Zaretskii
2013-07-15 5:45 ` Stephen J. Turnbull
2013-07-15 10:39 ` Óscar Fuentes
2013-08-02 15:32 ` Steinar Bang
2013-07-15 15:50 ` Eli Zaretskii
2013-07-14 18:33 ` Glenn Morris
2013-07-14 19:17 ` joakim
2013-07-15 10:51 ` Vitalie Spinu
2013-07-16 15:57 ` Glenn Morris
2013-07-16 21:26 ` Stefan Monnier
2013-07-17 7:29 ` Vitalie Spinu
2013-07-17 15:51 ` Vitalie Spinu
2013-07-18 8:47 ` Lars Magne Ingebrigtsen
2013-07-18 22:27 ` Vitalie Spinu
2013-07-19 9:22 ` Stefan Monnier
2013-07-20 7:25 ` Vitalie Spinu
2013-07-22 20:17 ` Vitalie Spinu
2013-07-22 20:31 ` Lars Magne Ingebrigtsen
2013-07-23 8:31 ` Vitalie Spinu
2013-07-18 23:22 ` image-transform.el and image-mode.el rewrite Vitalie Spinu
2013-07-19 11:52 ` Wolfgang Jenkner [this message]
2013-07-19 12:21 ` Wolfgang Jenkner
2013-07-20 7:18 ` Vitalie Spinu
2013-07-22 20:37 ` Glenn Morris
2013-07-22 21:05 ` Vitalie Spinu
2013-10-08 18:08 ` Glenn Morris
2013-10-08 23:43 ` Vitalie Spinu
2013-10-09 0:02 ` Michael Heerdegen
2014-12-15 9:33 ` Vitalie Spinu
2014-12-18 14:17 ` Michael Heerdegen
2014-12-18 21:32 ` Vitalie Spinu
2014-12-18 15:15 ` Stefan Monnier
2014-12-18 23:23 ` Vitalie Spinu
2014-12-19 4:19 ` Stefan Monnier
2014-12-19 4:46 ` Vitalie Spinu
2014-12-19 8:56 ` Eli Zaretskii
2014-12-19 17:50 ` Stefan Monnier
2014-12-19 19:37 ` Eli Zaretskii
2014-12-19 21:31 ` Stefan Monnier
2014-12-19 21:49 ` Eli Zaretskii
2014-12-19 10:24 ` Vitalie Spinu
2014-12-19 17:51 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85vc463gy7.fsf@inode.at \
--to=wjenkner@inode.at \
--cc=emacs-devel@gnu.org \
--cc=joakim@verona.se \
--cc=monnier@IRO.UMontreal.CA \
--cc=spinuvit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).