unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PCL-CVS] Menu entry for `cvs-mode-mark' missing
@ 2005-05-20 17:44 Reiner Steib
  2005-05-20 18:10 ` David Kastrup
  0 siblings, 1 reply; 7+ messages in thread
From: Reiner Steib @ 2005-05-20 17:44 UTC (permalink / raw)
  Cc: Stefan Monnier

Hi,

in PCL-CVS, the important command `cvs-mode-mark' (bound to `m')
doesn't have a menu entry.  Is this intended?  Else I'd like to add
it:

2005-05-20  Reiner Steib  <Reiner.Steib@gmx.de>

	* pcvs-defs.el (cvs-menu): Add cvs-mode-mark.

--8<---------------cut here---------------start------------->8---
--- pcvs-defs.el	17 Dec 2004 16:17:35 +0100	1.30
+++ pcvs-defs.el	20 May 2005 19:34:54 +0200	
@@ -421,6 +421,7 @@
     ["Ignore"			cvs-mode-ignore		(cvs-enabledp 'ignore)]
     ["Add ChangeLog"		cvs-mode-add-change-log-entry-other-window t]
     "----"
+    ["Mark current"		cvs-mode-mark	t]
     ["Mark all"			cvs-mode-mark-all-files	t]
     ["Mark by regexp..."        cvs-mode-mark-matching-files t]
     ["Mark by state..."         cvs-mode-mark-on-state t]
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PCL-CVS] Menu entry for `cvs-mode-mark' missing
  2005-05-20 17:44 [PCL-CVS] Menu entry for `cvs-mode-mark' missing Reiner Steib
@ 2005-05-20 18:10 ` David Kastrup
  2005-05-20 18:54   ` Reiner Steib
  0 siblings, 1 reply; 7+ messages in thread
From: David Kastrup @ 2005-05-20 18:10 UTC (permalink / raw)
  Cc: Stefan Monnier

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> in PCL-CVS, the important command `cvs-mode-mark' (bound to `m')
> doesn't have a menu entry.  Is this intended?  Else I'd like to add
> it:
>
> 2005-05-20  Reiner Steib  <Reiner.Steib@gmx.de>
>
> 	* pcvs-defs.el (cvs-menu): Add cvs-mode-mark.
>
> --8<---------------cut here---------------start------------->8---
> --- pcvs-defs.el	17 Dec 2004 16:17:35 +0100	1.30
> +++ pcvs-defs.el	20 May 2005 19:34:54 +0200	
> @@ -421,6 +421,7 @@
>      ["Ignore"			cvs-mode-ignore		(cvs-enabledp 'ignore)]
>      ["Add ChangeLog"		cvs-mode-add-change-log-entry-other-window t]
>      "----"
> +    ["Mark current"		cvs-mode-mark	t]
>      ["Mark all"			cvs-mode-mark-all-files	t]
>      ["Mark by regexp..."        cvs-mode-mark-matching-files t]
>      ["Mark by state..."         cvs-mode-mark-on-state t]
> --8<---------------cut here---------------end--------------->8---

The equivalent in Dired mode is just called "Mark".  Maybe one should
keep this consistent.  And it would appear that "Unmark" would be
desirable as well.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PCL-CVS] Menu entry for `cvs-mode-mark' missing
  2005-05-20 18:10 ` David Kastrup
@ 2005-05-20 18:54   ` Reiner Steib
  2005-05-20 20:38     ` Stefan Monnier
  0 siblings, 1 reply; 7+ messages in thread
From: Reiner Steib @ 2005-05-20 18:54 UTC (permalink / raw)
  Cc: Stefan Monnier, Emacs development

On Fri, May 20 2005, David Kastrup wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> in PCL-CVS, the important command `cvs-mode-mark' (bound to `m')
>> doesn't have a menu entry.  Is this intended?  Else I'd like to add
>> it:
[...]
>> +    ["Mark current"		cvs-mode-mark	t]
[...]
> The equivalent in Dired mode is just called "Mark".  Maybe one should
> keep this consistent.  And it would appear that "Unmark" would be
> desirable as well.

I agree:

--8<---------------cut here---------------start------------->8---
--- pcvs-defs.el	17 Dec 2004 16:17:35 +0100	1.30
+++ pcvs-defs.el	20 May 2005 20:49:45 +0200	
@@ -421,6 +421,8 @@
     ["Ignore"			cvs-mode-ignore		(cvs-enabledp 'ignore)]
     ["Add ChangeLog"		cvs-mode-add-change-log-entry-other-window t]
     "----"
+    ["Mark"                     cvs-mode-mark t]
+    ["Unmark"                   cvs-mode-unmark	t]
     ["Mark all"			cvs-mode-mark-all-files	t]
     ["Mark by regexp..."        cvs-mode-mark-matching-files t]
     ["Mark by state..."         cvs-mode-mark-on-state t]
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PCL-CVS] Menu entry for `cvs-mode-mark' missing
  2005-05-20 18:54   ` Reiner Steib
@ 2005-05-20 20:38     ` Stefan Monnier
  2005-05-20 20:44       ` David Kastrup
  0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2005-05-20 20:38 UTC (permalink / raw)
  Cc: Emacs development

> --8<---------------cut here---------------start------------->8---
> --- pcvs-defs.el	17 Dec 2004 16:17:35 +0100	1.30
> +++ pcvs-defs.el	20 May 2005 20:49:45 +0200	
> @@ -421,6 +421,8 @@
>      ["Ignore"			cvs-mode-ignore		(cvs-enabledp 'ignore)]
>      ["Add ChangeLog"		cvs-mode-add-change-log-entry-other-window t]
>      "----"
> +    ["Mark"                     cvs-mode-mark t]
> +    ["Unmark"                   cvs-mode-unmark	t]
>      ["Mark all"			cvs-mode-mark-all-files	t]
>      ["Mark by regexp..."        cvs-mode-mark-matching-files t]
>      ["Mark by state..."         cvs-mode-mark-on-state t]
> --8<---------------cut here---------------end--------------->8---

I have no opinion on such matters, so if people like it, they should
install it.  I personally find the menu completely unusable anyway, so its
only value is in listing key-bindings.


        Stefan

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PCL-CVS] Menu entry for `cvs-mode-mark' missing
  2005-05-20 20:38     ` Stefan Monnier
@ 2005-05-20 20:44       ` David Kastrup
  2005-05-20 20:52         ` Stefan Monnier
  0 siblings, 1 reply; 7+ messages in thread
From: David Kastrup @ 2005-05-20 20:44 UTC (permalink / raw)
  Cc: Emacs development

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> --8<---------------cut here---------------start------------->8---
>> --- pcvs-defs.el	17 Dec 2004 16:17:35 +0100	1.30
>> +++ pcvs-defs.el	20 May 2005 20:49:45 +0200	
>> @@ -421,6 +421,8 @@
>>      ["Ignore"			cvs-mode-ignore		(cvs-enabledp 'ignore)]
>>      ["Add ChangeLog"		cvs-mode-add-change-log-entry-other-window t]
>>      "----"
>> +    ["Mark"                     cvs-mode-mark t]
>> +    ["Unmark"                   cvs-mode-unmark	t]
>>      ["Mark all"			cvs-mode-mark-all-files	t]
>>      ["Mark by regexp..."        cvs-mode-mark-matching-files t]
>>      ["Mark by state..."         cvs-mode-mark-on-state t]
>> --8<---------------cut here---------------end--------------->8---
>
> I have no opinion on such matters, so if people like it, they should
> install it.  I personally find the menu completely unusable anyway, so its
> only value is in listing key-bindings.

Well, then it should list the most frequent key-bindings...

Do you find _this_ menu completely unusable, or menus in general?  If
the former, then maybe it can be improved.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PCL-CVS] Menu entry for `cvs-mode-mark' missing
  2005-05-20 20:44       ` David Kastrup
@ 2005-05-20 20:52         ` Stefan Monnier
  2005-06-21 13:40           ` Reiner Steib
  0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2005-05-20 20:52 UTC (permalink / raw)
  Cc: Emacs development

> Do you find _this_ menu completely unusable, or menus in general?  If
> the former, then maybe it can be improved.

This menu in particular.
But I have no idea how to improve it, so AFAIC no change can make
it worse: feel free to change it.


        Stefan

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PCL-CVS] Menu entry for `cvs-mode-mark' missing
  2005-05-20 20:52         ` Stefan Monnier
@ 2005-06-21 13:40           ` Reiner Steib
  0 siblings, 0 replies; 7+ messages in thread
From: Reiner Steib @ 2005-06-21 13:40 UTC (permalink / raw)


On Fri, May 20 2005, Stefan Monnier wrote:

>> Do you find _this_ menu completely unusable, or menus in general?  If
>> the former, then maybe it can be improved.
>
> This menu in particular.
> But I have no idea how to improve it, so AFAIC no change can make
> it worse: feel free to change it.

Added cvs-mode-mark and cvs-mode-unmark.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2005-06-21 13:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-20 17:44 [PCL-CVS] Menu entry for `cvs-mode-mark' missing Reiner Steib
2005-05-20 18:10 ` David Kastrup
2005-05-20 18:54   ` Reiner Steib
2005-05-20 20:38     ` Stefan Monnier
2005-05-20 20:44       ` David Kastrup
2005-05-20 20:52         ` Stefan Monnier
2005-06-21 13:40           ` Reiner Steib

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).