From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: Generalizing find-definition Date: Wed, 19 Nov 2014 18:15:54 -0600 Message-ID: <85siheg211.fsf@stephe-leake.org> References: <20141102151524.0d9c665c@forcix> <20141117211039.37f03409@forcix> <85ppclgcec.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416442592 859 80.91.229.3 (20 Nov 2014 00:16:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Nov 2014 00:16:32 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 20 01:16:25 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrFQ7-0002hm-6u for ged-emacs-devel@m.gmane.org; Thu, 20 Nov 2014 01:16:23 +0100 Original-Received: from localhost ([::1]:33007 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrFQ6-0001ml-Nf for ged-emacs-devel@m.gmane.org; Wed, 19 Nov 2014 19:16:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrFPp-0001mf-AP for emacs-devel@gnu.org; Wed, 19 Nov 2014 19:16:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrFPj-0000rT-Dq for emacs-devel@gnu.org; Wed, 19 Nov 2014 19:16:05 -0500 Original-Received: from dnvrco-outbound-snat.email.rr.com ([107.14.73.226]:39985 helo=dnvrco-oedge-vip.email.rr.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrFPj-0000kQ-8K for emacs-devel@gnu.org; Wed, 19 Nov 2014 19:15:59 -0500 Original-Received: from [70.94.38.149] ([70.94.38.149:57000] helo=TAKVER) by dnvrco-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id 16/F6-03650-BB23D645; Thu, 20 Nov 2014 00:15:56 +0000 In-Reply-To: (Stefan Monnier's message of "Wed, 19 Nov 2014 09:27:58 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.94 (windows-nt) X-RR-Connecting-IP: 107.14.64.118:25 X-Authority-Analysis: v=2.1 cv=T4ICTp6Q c=1 sm=1 tr=0 a=AppmJ/7ZOOFWL/q6u6u93g==:117 a=AppmJ/7ZOOFWL/q6u6u93g==:17 a=ayC55rCoAAAA:8 a=fNEgcOh0sVsA:10 a=9i_RQKNPAAAA:8 a=uDIy64cP4Q9fNXU8oXEA:9 X-Cloudmark-Score: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 107.14.73.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:177835 Archived-At: Stefan Monnier writes: >>> +(defvar find-definition-function nil >>> +(defvar find-definition-identifier-function nil >> These variables will be set by the major mode, so they should be >> buffer-local; use defvar-local. > > Bad idea: if the major modes set those with `setq' rather than with > `setq-local', they'll end up setting the global value if the `setq' > happens to be run before loading find-definition.el (which is quite > possible since find-definition.el will typically be loaded via an > autoload rather than via a `require'). This _should_ be caught by a byte-compiler warning ("find-definition-function not known"). So I'm ok with requiring major modes to either have "(require find-definition)" or use setq-local. -- -- Stephe