unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
To: "Juanma Barranquero" <lekktu@gmail.com>
Cc: "山本和彦 Kazu Yamamoto" <kazu@iij.ad.jp>, emacs-devel@gnu.org
Subject: Re: unused local variables
Date: Fri, 30 Nov 2007 10:59:57 +0100	[thread overview]
Message-ID: <85r6i812aq.fsf@lola.goethe.zz> (raw)
In-Reply-To: <f7ccd24b0711300137s49de9416ka2ac10116aca8448@mail.gmail.com> (Juanma Barranquero's message of "Fri, 30 Nov 2007 10:37:55 +0100")

"Juanma Barranquero" <lekktu@gmail.com> writes:

> On Nov 30, 2007 10:27 AM, 山本和彦 Kazu Yamamoto <kazu@iij.ad.jp> wrote:
>
>> XEmacs warns unused local variables as if they are statically bound.
>> Also XEmacs does not warns unused local variables if they are
>> also globally defined.
>
> Are you saying that in
>
>  (defun test ()
>    (if my-dynamic-var
>        "correct"
>      "erroneous"))
>
>  (let ((my-dynamic-var t))
>    (test))
>
> you would force my-dynamic-var to be `defvar'ed to avoid a warning in
> the let?

I consider this quite reasonable.  If my-dynamic-var is used for passing
information across function boundaries, it deserves being declared in
the same scope.  There is one obvious exception:

(defun test ()
  (let ((my-variable 3))
    (funcall (lambda nil (1+ my-variable)))))

Namely, lambda functions using upvalues (well, conceptually as long as
we don't have closures).  Those are byte-compiled as well and should not
complain.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

  reply	other threads:[~2007-11-30  9:59 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29 12:32 unused local variables Kazu Yamamoto
2007-11-29 15:31 ` Thien-Thi Nguyen
2007-11-30  0:23   ` Kazu Yamamoto
2007-11-30  9:22     ` Juanma Barranquero
2007-11-30  9:27       ` Kazu Yamamoto
2007-11-30  9:37         ` Juanma Barranquero
2007-11-30  9:59           ` David Kastrup [this message]
2007-11-30 10:14             ` Juanma Barranquero
2007-11-30 10:23               ` David Kastrup
2007-11-30 10:26                 ` Juanma Barranquero
2007-11-30 10:36                   ` David Kastrup
2007-11-30 10:49                     ` Juanma Barranquero
2007-11-30 10:34           ` Kazu Yamamoto
2007-11-30 10:45             ` Juanma Barranquero
2007-11-30 11:26               ` David Kastrup
2007-11-30 11:39                 ` Juanma Barranquero
2007-12-03  2:30               ` Kazu Yamamoto
2007-12-03  9:50                 ` Juanma Barranquero
2007-12-03 10:03                   ` Kazu Yamamoto
2007-11-30 15:10           ` Stefan Monnier
2007-11-30 15:31             ` Juanma Barranquero
2007-11-30 15:58               ` Stefan Monnier
2007-11-30 16:40                 ` David Kastrup
2007-11-30 17:58                   ` tomas
2007-11-30 18:07                 ` Juanma Barranquero
2007-11-30 15:38             ` Juanma Barranquero
2007-11-30 15:59               ` Stefan Monnier
2007-11-30 18:11                 ` Juanma Barranquero
2007-12-01  3:17                   ` Stefan Monnier
2007-11-29 16:02 ` Stefan Monnier
2007-11-30  0:25   ` Kazu Yamamoto
2007-12-04 11:12 ` Katsumi Yamaoka
2007-12-04 15:28   ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85r6i812aq.fsf@lola.goethe.zz \
    --to=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kazu@iij.ad.jp \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).