From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Info bug Date: Tue, 22 Apr 2008 07:59:37 +0200 Message-ID: <85r6cytoom.fsf@lola.goethe.zz> References: <87iqybasft.fsf@stupidchicken.com> <87fxte7q9f.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208845540 29306 80.91.229.12 (22 Apr 2008 06:25:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Apr 2008 06:25:40 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 22 08:26:15 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JoBx5-00011C-O3 for ged-emacs-devel@m.gmane.org; Tue, 22 Apr 2008 08:26:04 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JoBwQ-0002qk-3V for ged-emacs-devel@m.gmane.org; Tue, 22 Apr 2008 02:25:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JoBby-0006Aj-AX for emacs-devel@gnu.org; Tue, 22 Apr 2008 02:04:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JoBbe-0005wz-4d for emacs-devel@gnu.org; Tue, 22 Apr 2008 02:03:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JoBbb-0005sA-G3 for emacs-devel@gnu.org; Tue, 22 Apr 2008 02:03:51 -0400 Original-Received: from mail-in-10.arcor-online.net ([151.189.21.50]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JoBXi-0006v0-Ct for emacs-devel@gnu.org; Tue, 22 Apr 2008 01:59:50 -0400 Original-Received: from mail-in-06-z2.arcor-online.net (mail-in-06-z2.arcor-online.net [151.189.8.18]) by mail-in-10.arcor-online.net (Postfix) with ESMTP id F3CE51F4FA2; Tue, 22 Apr 2008 07:59:47 +0200 (CEST) Original-Received: from mail-in-03.arcor-online.net (mail-in-03.arcor-online.net [151.189.21.43]) by mail-in-06-z2.arcor-online.net (Postfix) with ESMTP id E3F6C5C2BD; Tue, 22 Apr 2008 07:59:47 +0200 (CEST) Original-Received: from lola.goethe.zz (dslb-084-061-039-221.pools.arcor-ip.net [84.61.39.221]) by mail-in-03.arcor-online.net (Postfix) with ESMTP id C2F4130AC27; Tue, 22 Apr 2008 07:59:47 +0200 (CEST) Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id 5EDCD1C3C7BC; Tue, 22 Apr 2008 07:59:37 +0200 (CEST) In-Reply-To: <87fxte7q9f.fsf@jurta.org> (Juri Linkov's message of "Tue, 22 Apr 2008 02:16:28 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Virus-Scanned: ClamAV 0.92.1/6878/Tue Apr 22 05:45:17 2008 on mail-in-03.arcor-online.net X-Virus-Status: Clean X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95743 Archived-At: Juri Linkov writes: >> Due to a recent change to Info, I see the following bug: >> >> emacs -Q >> M-x info RET -> Point is on the last info link, instead of point-min. >> >> Could anyone who changed Info in the last few days please double-check >> your work and see if you introduced this bug? > > This is caused by the following change in `Info-complete-menu-item': > > @@ -2271,8 +2262,7 @@ > ;; Note that `Info-complete-menu-buffer' could be current already, > ;; so we want to save point. > - (save-excursion > - (set-buffer Info-complete-menu-buffer) > + (with-current-buffer Info-complete-menu-buffer > (let ((completion-ignore-case t) > (case-fold-search t) > (orignode Info-current-node) > > In theory, these constructs should be equivalent, but they are not. Read the comment above the change. It describes the rationale for the original code and does not jibe with the new code. You are probably thinking of save-current-buffer rather than save-excursion. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum