From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: Generalizing find-definition Date: Tue, 18 Nov 2014 02:07:23 -0600 Message-ID: <85ppclgcec.fsf@stephe-leake.org> References: <20141102151524.0d9c665c@forcix> <20141117211039.37f03409@forcix> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416298081 9878 80.91.229.3 (18 Nov 2014 08:08:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 18 Nov 2014 08:08:01 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 18 09:07:54 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XqdpF-00051W-QH for ged-emacs-devel@m.gmane.org; Tue, 18 Nov 2014 09:07:49 +0100 Original-Received: from localhost ([::1]:51747 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqdpF-00053I-8s for ged-emacs-devel@m.gmane.org; Tue, 18 Nov 2014 03:07:49 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xqdow-00053C-Og for emacs-devel@gnu.org; Tue, 18 Nov 2014 03:07:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xqdoq-0006AK-GF for emacs-devel@gnu.org; Tue, 18 Nov 2014 03:07:30 -0500 Original-Received: from dnvrco-outbound-snat.email.rr.com ([107.14.73.225]:65053 helo=dnvrco-oedge-vip.email.rr.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xqdoq-00068j-Ao for emacs-devel@gnu.org; Tue, 18 Nov 2014 03:07:24 -0500 Original-Received: from [70.94.38.149] ([70.94.38.149:53578] helo=TAKVER) by dnvrco-oedge03 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id E8/3E-19850-B3EFA645; Tue, 18 Nov 2014 08:07:23 +0000 In-Reply-To: <20141117211039.37f03409@forcix> (Jorgen Schaefer's message of "Mon, 17 Nov 2014 21:10:39 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.94 (windows-nt) X-RR-Connecting-IP: 107.14.64.142:25 X-Authority-Analysis: v=2.1 cv=DPcB4k9b c=1 sm=1 tr=0 a=AppmJ/7ZOOFWL/q6u6u93g==:117 a=AppmJ/7ZOOFWL/q6u6u93g==:17 a=ayC55rCoAAAA:8 a=fNEgcOh0sVsA:10 a=9i_RQKNPAAAA:8 a=PZ3frYkpJm3W4MUDKfwA:9 X-Cloudmark-Score: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 107.14.73.225 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:177525 Archived-At: Jorgen Schaefer writes: > This also does define a minor mode instead of changing the global key > bindings. I think in the final version it should replace the key binding > definitions done in etags.el. Is this correct? +1 > Do I need to hook it up elsewhere in the build process? Not sure what you are asking here; the keybindings need to be autoloaded as in etags.el. > +(defvar find-definition-function nil > +(defvar find-definition-identifier-function nil These variables will be set by the major mode, so they should be buffer-local; use defvar-local. > +(defvar find-definition-marker-ring > + (make-ring find-definition-marker-ring-length) > + "Ring of positions visited by `find-definition'.") This variable might want to be mode-specific, but not buffer-local; I'm not sure how to accomplish that. -- -- Stephe