From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Bug fix in isearch.el Date: Tue, 03 Oct 2006 11:59:30 +0200 Message-ID: <85odst1zzx.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1159869614 11250 80.91.229.2 (3 Oct 2006 10:00:14 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 3 Oct 2006 10:00:14 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 03 12:00:10 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GUh4E-0000OM-3u for ged-emacs-devel@m.gmane.org; Tue, 03 Oct 2006 12:00:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GUh4B-00081Q-Rw for ged-emacs-devel@m.gmane.org; Tue, 03 Oct 2006 05:59:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GUh3z-0007zB-Dn for emacs-devel@gnu.org; Tue, 03 Oct 2006 05:59:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GUh3y-0007yR-Uv for emacs-devel@gnu.org; Tue, 03 Oct 2006 05:59:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GUh3y-0007yI-Lj for emacs-devel@gnu.org; Tue, 03 Oct 2006 05:59:46 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GUhA9-0004N1-Qa for emacs-devel@gnu.org; Tue, 03 Oct 2006 06:06:09 -0400 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1GUh3x-0001jd-TR for emacs-devel@gnu.org; Tue, 03 Oct 2006 05:59:46 -0400 Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id E0D7D1C39502; Tue, 3 Oct 2006 11:59:30 +0200 (CEST) Original-To: emacs-devel@gnu.org User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:60386 Archived-At: --=-=-= Anything speaking against the following patch? It would end the annoyance that clicking with mouse-2 on a clickable overlay when doing isearch would rather cause a paste to occur. This has been bothering me for years, and now it can be fixed reasonably easy. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable Index: lisp/isearch.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/isearch.el,v retrieving revision 1.290 diff -u -r1.290 isearch.el *** lisp/isearch.el 20 Sep 2006 06:13:43 -0000 1.290 --- lisp/isearch.el 3 Oct 2006 09:55:18 -0000 *************** *** 1297,1313 **** (interactive "e") (let* ((w (posn-window (event-start click))) (overriding-terminal-local-map nil) ! (key (vector (event-basic-type click))) ! ;; FIXME: `key-binding' should accept an event as argument ! ;; and do all the overlay/text-properties lookup etc... ! (binding (with-current-buffer ! (if (window-live-p w) (window-buffer w) (current-buffer)) ! (key-binding key)))) (if (and (window-minibuffer-p w) (not (minibuffer-window-active-p w))) ; in echo area (isearch-yank-x-selection) (when (functionp binding) ! (call-interactively binding))))) =20 =20 (defun isearch-yank-internal (jumpform) --- 1297,1311 ---- (interactive "e") (let* ((w (posn-window (event-start click))) (overriding-terminal-local-map nil) ! ;; Should we rather use the output of `this-command-keys-vector' ! ;; instead of `(vector click)' for `keys'? ! (keys (vector click)) ! (binding (key-binding keys t))) (if (and (window-minibuffer-p w) (not (minibuffer-window-active-p w))) ; in echo area (isearch-yank-x-selection) (when (functionp binding) ! (call-interactively binding nil keys))))) =20 =20 (defun isearch-yank-internal (jumpform) Index: lisp/ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/ChangeLog,v retrieving revision 1.10156 diff -u -r1.10156 ChangeLog *** lisp/ChangeLog 2 Oct 2006 23:26:42 -0000 1.10156 --- lisp/ChangeLog 3 Oct 2006 09:55:50 -0000 *************** *** 1,3 **** --- 1,10 ---- + 2006-10-03 David Kastrup +=20 + * isearch.el (isearch-mouse-2): Use new semantics of `key-binding' + in order to better redirect mouse-2 clicks. Also allow default + bindings to apply, and pass the synthetic key-sequence to + `call-interactively'. +=20 2006-10-03 Denis St=1B,A|=1B(Bnkel (tiny = change) =20 * ibuf-ext.el (eval, view-and-eval) : --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --=-=-=--