From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: Generalizing find-definition Date: Wed, 19 Nov 2014 18:21:29 -0600 Message-ID: <85oas2g1rq.fsf@stephe-leake.org> References: <20141102151524.0d9c665c@forcix> <20141117211039.37f03409@forcix> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416442914 5258 80.91.229.3 (20 Nov 2014 00:21:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Nov 2014 00:21:54 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 20 01:21:47 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrFVL-0004QS-HJ for ged-emacs-devel@m.gmane.org; Thu, 20 Nov 2014 01:21:47 +0100 Original-Received: from localhost ([::1]:33023 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrFVK-0002jr-Um for ged-emacs-devel@m.gmane.org; Wed, 19 Nov 2014 19:21:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrFVB-0002ja-HK for emacs-devel@gnu.org; Wed, 19 Nov 2014 19:21:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrFV5-0002fT-Jy for emacs-devel@gnu.org; Wed, 19 Nov 2014 19:21:37 -0500 Original-Received: from dnvrco-outbound-snat.email.rr.com ([107.14.73.227]:44334 helo=dnvrco-oedge-vip.email.rr.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrFV5-0002fI-FC for emacs-devel@gnu.org; Wed, 19 Nov 2014 19:21:31 -0500 Original-Received: from [70.94.38.149] ([70.94.38.149:57005] helo=TAKVER) by dnvrco-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id B1/B9-03650-A043D645; Thu, 20 Nov 2014 00:21:30 +0000 In-Reply-To: (Stefan Monnier's message of "Tue, 18 Nov 2014 11:31:29 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.94 (windows-nt) X-RR-Connecting-IP: 107.14.64.118:25 X-Authority-Analysis: v=2.1 cv=T4ICTp6Q c=1 sm=1 tr=0 a=AppmJ/7ZOOFWL/q6u6u93g==:117 a=AppmJ/7ZOOFWL/q6u6u93g==:17 a=ayC55rCoAAAA:8 a=fNEgcOh0sVsA:10 a=9i_RQKNPAAAA:8 a=J7K2Tc5VcBPVhxRCa7EA:9 X-Cloudmark-Score: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 107.14.73.227 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:177836 Archived-At: Stefan Monnier writes: >> +(defvar find-definition-identifier-function nil > > I suggest you collapse those two function variables into one: if called > with a nil value (or without argument), then just find the definitions > of "thing at point" and if called with a string, then find the > definitions of that identifier. Keeping two variables puts that logic in the front-end, so all the backends don't have to implement it, and we can change it for everyone consistently. -- -- Stephe