From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: [bug] read-passwd of CVS Emacs Date: Thu, 25 May 2006 00:08:48 +0200 Message-ID: <85lksr2hzj.fsf@lola.goethe.zz> References: <20060524.123750.178780620.kazu@iij.ad.jp> <85u07f2xfq.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1148508603 26261 80.91.229.2 (24 May 2006 22:10:03 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 24 May 2006 22:10:03 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 25 00:10:01 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fj1YF-0001qN-GP for ged-emacs-devel@m.gmane.org; Thu, 25 May 2006 00:10:00 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fj1YE-0008Pg-Co for ged-emacs-devel@m.gmane.org; Wed, 24 May 2006 18:09:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fj1Y2-0008Pb-LZ for emacs-devel@gnu.org; Wed, 24 May 2006 18:09:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fj1Y2-0008PP-68 for emacs-devel@gnu.org; Wed, 24 May 2006 18:09:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fj1Y2-0008PM-1c for emacs-devel@gnu.org; Wed, 24 May 2006 18:09:46 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fj1cY-0000ND-GZ for emacs-devel@gnu.org; Wed, 24 May 2006 18:14:26 -0400 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1Fj1Xw-0003YM-Ba; Wed, 24 May 2006 18:09:41 -0400 Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id 1D4B81CE3148; Thu, 25 May 2006 00:08:48 +0200 (CEST) Original-To: Kevin Rodgers In-Reply-To: (Kevin Rodgers's message of "Wed, 24 May 2006 12:29:07 -0600") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55230 Archived-At: Kevin Rodgers writes: > David Kastrup wrote: >> Kevin Rodgers writes: >> >>> Kazu Yamamoto (=E5=B1=B1=E6=9C=AC=E5=92=8C=E5=BD=A6) wrote: >>>> If the CONFIRM argument is specified to read-passwd of CVS Emacs, it >>>> causes an error after a user type a first password. >>>> >>>> (read-passwd "password: " t) >>> The error is "Attempt to modify read-only object" and is somehow caused >>> by a string indexing bug. Here's a patch: > ... >> Looks like causing trouble when the prompt is an empty string. And it >> looks like it would leave the properties off the last character of the >> prompt. Correct? > > You're right on both counts -- thanks for catching that! I should have > investigated further before posting a patch that has nothing to do with > the underlying error. > > The strange thing is that the error is definitely triggered by the call > to add-text-properties, but only in the second recursive call (not the > first): Maybe because adding text properties to an already read-only text is prohibited? In that case one would either have to refrain from doing it, or bind inhibit-read-only to t while doing it. --=20 David Kastrup, Kriemhildstr. 15, 44793 Bochum