Re: [bug] read-passwd of CVS Emacs

[David Kastrup <dak@gnu.org>]

Kevin Rodgers <ihs_4664@yahoo.com> writes:

> David Kastrup wrote:
>> Kevin Rodgers <ihs_4664@yahoo.com> writes:
>>
>>> Kazu Yamamoto (山本和彦) wrote:
>>>> If the CONFIRM argument is specified to read-passwd of CVS Emacs, it
>>>> causes an error after a user type a first password.
>>>>
>>>> 	(read-passwd "password: " t)
>>> The error is "Attempt to modify read-only object" and is somehow caused
>>> by a string indexing bug.  Here's a patch:
> ...
>> Looks like causing trouble when the prompt is an empty string.  And it
>> looks like it would leave the properties off the last character of the
>> prompt.  Correct?
>
> You're right on both counts -- thanks for catching that!  I should have
> investigated further before posting a patch that has nothing to do with
> the underlying error.
>
> The strange thing is that the error is definitely triggered by the call
> to add-text-properties, but only in the second recursive call (not the
> first):

Maybe because adding text properties to an already read-only text is
prohibited?  In that case one would either have to refrain from doing
it, or bind inhibit-read-only to t while doing it.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum