From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Quote file name args to start-process-shell-command? Date: Thu, 12 Oct 2006 10:24:47 +0200 Message-ID: <85lknmosa8.fsf@lola.goethe.zz> References: <452D54D8.7060705@student.lu.se> <452DDBC8.2060606@student.lu.se> <85y7rmou5t.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1160641700 4067 80.91.229.2 (12 Oct 2006 08:28:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 12 Oct 2006 08:28:20 +0000 (UTC) Cc: Lennart Borgman , Eli Zaretskii , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 12 10:28:18 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GXvts-0002Sq-6G for ged-emacs-devel@m.gmane.org; Thu, 12 Oct 2006 10:26:44 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GXvtr-00013O-BY for ged-emacs-devel@m.gmane.org; Thu, 12 Oct 2006 04:26:43 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GXvsp-0000o6-Pk for emacs-devel@gnu.org; Thu, 12 Oct 2006 04:25:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GXvsk-0000ky-63 for emacs-devel@gnu.org; Thu, 12 Oct 2006 04:25:38 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GXvsj-0000kR-Ka for emacs-devel@gnu.org; Thu, 12 Oct 2006 04:25:33 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GXw0v-0007Ak-0E for emacs-devel@gnu.org; Thu, 12 Oct 2006 04:34:01 -0400 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1GXvsh-0000q2-Sv; Thu, 12 Oct 2006 04:25:32 -0400 Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id 769441CE169B; Thu, 12 Oct 2006 10:24:47 +0200 (CEST) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "Thu\, 12 Oct 2006 10\:15\:38 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:60632 Archived-At: storm@cua.dk (Kim F. Storm) writes: > David Kastrup writes: > >> One would have to look at the actual use cases to see whether any >> caller assumes differently, but from the description, I'd agree >> with Lennart's idea. > > But it would break any uses where the caller already has used > shell-quote-argument. > > Let's leave the API alone It appears broken to me, but fixing it in a backwards-compatible way does not seem possible without further messing the API up. The question is how much actual code might be affected by a non backwards-compatible change of the API. I never heard of the function until now. > -- but it would be ok to mention the use of shell-quote-argument in > the doc string. I'd prefer fixing the function instead. A command API should take either a single string, or a list of individual arguments. A list of individual arguments which get concatened into a single string that is later split into individual arguments in a different way: that simply is not a useful concept to wrap into calling conventions. The current API suggests a usage that does not actually work. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum