From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Updated project-specific settings patch Date: Mon, 19 May 2008 22:29:24 +0200 Message-ID: <85lk26qbq3.fsf@lola.goethe.zz> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1211229055 2214 80.91.229.12 (19 May 2008 20:30:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 May 2008 20:30:55 +0000 (UTC) Cc: tromey@redhat.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 19 22:31:31 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JyBzy-000330-5w for ged-emacs-devel@m.gmane.org; Mon, 19 May 2008 22:30:22 +0200 Original-Received: from localhost ([127.0.0.1]:58091 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyBzE-000059-7j for ged-emacs-devel@m.gmane.org; Mon, 19 May 2008 16:29:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JyBz8-0008WO-Px for emacs-devel@gnu.org; Mon, 19 May 2008 16:29:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JyBz6-0008W5-Mt for emacs-devel@gnu.org; Mon, 19 May 2008 16:29:29 -0400 Original-Received: from [199.232.76.173] (port=47468 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyBz6-0008Vw-Fi for emacs-devel@gnu.org; Mon, 19 May 2008 16:29:28 -0400 Original-Received: from mail-in-06.arcor-online.net ([151.189.21.46]:33113) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JyBz4-00069m-QE for emacs-devel@gnu.org; Mon, 19 May 2008 16:29:27 -0400 Original-Received: from mail-in-15-z2.arcor-online.net (mail-in-15-z2.arcor-online.net [151.189.8.32]) by mail-in-06.arcor-online.net (Postfix) with ESMTP id C4E1131E97E; Mon, 19 May 2008 22:29:24 +0200 (CEST) Original-Received: from mail-in-14.arcor-online.net (mail-in-14.arcor-online.net [151.189.21.54]) by mail-in-15-z2.arcor-online.net (Postfix) with ESMTP id B3A5D72426C; Mon, 19 May 2008 22:29:24 +0200 (CEST) Original-Received: from lola.goethe.zz (dslb-084-061-097-114.pools.arcor-ip.net [84.61.97.114]) by mail-in-14.arcor-online.net (Postfix) with ESMTP id 8AFF21878DF; Mon, 19 May 2008 22:29:24 +0200 (CEST) Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id 206C21C464F9; Mon, 19 May 2008 22:29:24 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Mon, 19 May 2008 14:51:02 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Virus-Scanned: ClamAV 0.92.1/7171/Mon May 19 20:21:55 2008 on mail-in-14.arcor-online.net X-Virus-Status: Clean X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97410 Archived-At: Stefan Monnier writes: > Better use the same buffer name *Local Variables*. > >> + ((file-exists-p (concat dir ".dir-settings.el")) >> + (setq result (concat dir ".dir-settings.el"))) > > In most cases, we'd prefer (expand-file-name ".dir-settings.el" dir) > over the use of `concat'. The only exception I know is when `dir' is > relative and it's important for the result also be relative. If the file name or directory has been read directly from disk and thus may contain "~" or "~USER" as valid literal components, you don't want to have those expanded. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum