From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Code cleanup. Date: Mon, 23 Oct 2006 19:29:44 +0200 Message-ID: <85hcxvhref.fsf@lola.goethe.zz> References: <85y7r7l00o.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1161624751 9040 80.91.229.2 (23 Oct 2006 17:32:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 23 Oct 2006 17:32:31 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 23 19:32:27 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gc3en-0005Fw-IT for ged-emacs-devel@m.gmane.org; Mon, 23 Oct 2006 19:32:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gc3en-0007CK-1b for ged-emacs-devel@m.gmane.org; Mon, 23 Oct 2006 13:32:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gc3dP-0006WQ-C7 for emacs-devel@gnu.org; Mon, 23 Oct 2006 13:30:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gc3dN-0006UG-JH for emacs-devel@gnu.org; Mon, 23 Oct 2006 13:30:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gc3dN-0006U9-FD for emacs-devel@gnu.org; Mon, 23 Oct 2006 13:30:45 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gc3dN-0006Vv-F6 for emacs-devel@gnu.org; Mon, 23 Oct 2006 13:30:45 -0400 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1Gc3dM-00068E-5i; Mon, 23 Oct 2006 13:30:44 -0400 Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id 15DAD1CD3543; Mon, 23 Oct 2006 19:29:44 +0200 (CEST) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "Mon\, 23 Oct 2006 18\:50\:21 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61051 Archived-At: storm@cua.dk (Kim F. Storm) writes: > David Kastrup writes: > >> At what stage of development (if at all) should such janitorial >> changes be usually applied? > > Code cleanup is usually welcome -- but this is not the time. Sure. >> On a completely different tangent: wouldn't it be much more >> readable (though likely not completely correct in some perverse >> manner) if diff-mode actually had its TAB positions in column >> 9,17,25... instead of the customary 8,16,24...? At least in >> context and unified diffs, that would _much_ better reflect the >> relative indentation of the actual change than the current >> behavior. >> >> It does not look like `tab-width' can be made to do that, but maybe >> one could use a display property in order to move the information >> of column 0 into the fringe. > > Simpler would be to put the "diff decoration" in the left margin and > put the fringe outside the margins. Then the user wouldn't see any > difference (except that tabs line up correctly). Ah, I forgot the display margins. >> But it would probably be saner if tab-width were extended to allow, >> say, a cons-cell of initial offset and tab-width. > > Or a list (1 9 17 t) > (where t means to repeat tabs every "difference between last two > elements). Or a list (8 . #0) for repeated differences of 8, and (9 8 . #1) for that of 9. Too bad that this print syntax of (let ((n (list 9 8))) (setcdr (cdr n) (cdr n)) n) is not accepted by the Lisp reader. Circular lists are not really the most natural Lisp constructs... -- David Kastrup, Kriemhildstr. 15, 44793 Bochum